[net: PATCH] net: mvmdio: fix compilation warning

[net: PATCH] net: mvmdio: fix compilation warning

[Marcin Wojtas]

The kernel test robot reported a following issue:

>> drivers/net/ethernet/marvell/mvmdio.c:426:36: warning:
unused variable 'orion_mdio_acpi_match' [-Wunused-const-variable]
   static const struct acpi_device_id orion_mdio_acpi_match[] = {
                                      ^
   1 warning generated.

Fix that by surrounding the variable by appropriate ifdef.

Fixes: c54da4c1acb1 ("net: mvmdio: add ACPI support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 drivers/net/ethernet/marvell/mvmdio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
index 62a97c46fba0..ef878973b859 100644
--- a/drivers/net/ethernet/marvell/mvmdio.c
+++ b/drivers/net/ethernet/marvell/mvmdio.c
@@ -429,12 +429,14 @@ static const struct of_device_id orion_mdio_match[] = {
 };
 MODULE_DEVICE_TABLE(of, orion_mdio_match);
 
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id orion_mdio_acpi_match[] = {
 	{ "MRVL0100", BUS_TYPE_SMI },
 	{ "MRVL0101", BUS_TYPE_XSMI },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, orion_mdio_acpi_match);
+#endif
 
 static struct platform_driver orion_mdio_driver = {
 	.probe = orion_mdio_probe,
-- 
2.29.0

Re: [net: PATCH] net: mvmdio: fix compilation warning

[Andrew Lunn]

On Mon, Nov 15, 2021 at 04:30:24PM +0100, Marcin Wojtas wrote:
> The kernel test robot reported a following issue:
> 
> >> drivers/net/ethernet/marvell/mvmdio.c:426:36: warning:
> unused variable 'orion_mdio_acpi_match' [-Wunused-const-variable]
>    static const struct acpi_device_id orion_mdio_acpi_match[] = {

How come OF never gives these warning, just ACPI? If there something
missing in ACPI which OF has?

> Fixes: c54da4c1acb1 ("net: mvmdio: add ACPI support")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [net: PATCH] net: mvmdio: fix compilation warning

[Marcin Wojtas]

Hi Andrew,


pon., 15 lis 2021 o 20:35 Andrew Lunn <andrew@lunn.ch> napisał(a):
>
> On Mon, Nov 15, 2021 at 04:30:24PM +0100, Marcin Wojtas wrote:
> > The kernel test robot reported a following issue:
> >
> > >> drivers/net/ethernet/marvell/mvmdio.c:426:36: warning:
> > unused variable 'orion_mdio_acpi_match' [-Wunused-const-variable]
> >    static const struct acpi_device_id orion_mdio_acpi_match[] = {
>
> How come OF never gives these warning, just ACPI? If there something
> missing in ACPI which OF has?

It was enough to compile mvebu_v7_defconfig with W=1 to get it (so
CONFIG_ACPI disabled). There may be a similar case for config _OF, but
I couldn't deselect it easily and compile mvmdio at the same time.

>
> > Fixes: c54da4c1acb1 ("net: mvmdio: add ACPI support")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>

Thanks,
Marcin

Re: [net: PATCH] net: mvmdio: fix compilation warning

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 15 Nov 2021 16:30:24 +0100 you wrote:
> The kernel test robot reported a following issue:
> 
> >> drivers/net/ethernet/marvell/mvmdio.c:426:36: warning:
> unused variable 'orion_mdio_acpi_match' [-Wunused-const-variable]
>    static const struct acpi_device_id orion_mdio_acpi_match[] = {
>                                       ^
>    1 warning generated.
> 
> [...]

Here is the summary with links:
  - [net:] net: mvmdio: fix compilation warning
    https://git.kernel.org/netdev/net/c/2460386bef0b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html