From: Tejun Heo <tj@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
Date: Mon, 15 Nov 2021 11:38:02 -1000 [thread overview]
Message-ID: <YZLTOnv3PDmQMTKY@slm.duckdns.org> (raw)
In-Reply-To: <20211112093728.3237-1-lukas.bulwahn@gmail.com>
On Fri, Nov 12, 2021 at 10:37:28AM +0100, Lukas Bulwahn wrote:
> Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
> latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
> config BLK_CGROUP_IOCOST.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> BLK_RQ_IO_DATA_LEN
> Referencing files: block/Kconfig
>
> Probably, this select is just some unintended left-over from an earlier
> draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
> repository. So, drop this dead select to an undefined config.
>
> Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2021-11-16 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 9:37 [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN Lukas Bulwahn
2021-11-15 21:38 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZLTOnv3PDmQMTKY@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox