From: Vinod Koul <vkoul@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Doug Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] spi: spi-geni-qcom: Add support for GPI dma
Date: Wed, 17 Nov 2021 10:04:35 +0530 [thread overview]
Message-ID: <YZSGW7vNI04agVg3@matsya> (raw)
In-Reply-To: <YZPfJtkvo3bsfaCg@sirena.org.uk>
On 16-11-21, 16:41, Mark Brown wrote:
> On Tue, Nov 16, 2021 at 09:27:59PM +0530, Vinod Koul wrote:
> > On 03-11-21, 14:17, Doug Anderson wrote:
>
> > > if (result->residue) {
> > > dev_err(...);
> > > return;
> > > }
> > > spi_finalize_current_transfer(...);
>
> > Should we always call spi_finalize_current_transfer() ? This way we
> > timeout... What is the way to signal error has occurred..?
>
> Yes, set an error in the transfer and then finalize it.
Sure will do, thanks for confirming Mark
--
~Vinod
prev parent reply other threads:[~2021-11-17 4:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 6:09 [PATCH v5] spi: spi-geni-qcom: Add support for GPI dma Vinod Koul
2021-10-29 21:01 ` Mark Brown
2021-11-03 21:17 ` Doug Anderson
2021-11-16 15:57 ` Vinod Koul
2021-11-16 16:41 ` Mark Brown
2021-11-17 4:34 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZSGW7vNI04agVg3@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mka@chromium.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox