From: Vinod Koul <vkoul@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Peter Collingbourne <pcc@google.com>,
Robert Foss <robert.foss@linaro.org>,
Anibal Limon <anibal.limon@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lontium-lt9611: check a different register bit for HDMI sensing
Date: Wed, 17 Nov 2021 10:40:38 +0530 [thread overview]
Message-ID: <YZSOzhygBRli1DVh@matsya> (raw)
In-Reply-To: <CALAqxLWn67emfDPcMGrjVag0zCCrNF2=rEiHKQgr2eJ8AotCPg@mail.gmail.com>
Hi John,
On 16-11-21, 20:47, John Stultz wrote:
> On Tue, Nov 16, 2021 at 6:07 PM Peter Collingbourne <pcc@google.com> wrote:
> >
> > It has been observed that with certain monitors such as the HP Z27n,
> > the register 0x825e reads a value of 0x79 when the HDMI cable is
> > connected and 0x78 when it is disconnected, i.e. bit 0 appears
> > to correspond to the HDMI connection status and bit 2 is never
> > set. Therefore, change the driver to check bit 0 instead of bit 2.
> >
> > Signed-off-by: Peter Collingbourne <pcc@google.com>
> > Link: https://linux-review.googlesource.com/id/I7e76411127e1ce4988a3f6d0c8ba5f1c3d880c23
> > ---
> > N.B. I don't currently have easy access to a monitor that works
> > with the existing driver, so it would be great if people with
> > monitors that currently work could test this patch to make sure
> > that it doesn't introduce any regressions. Otherwise I will change
> > it to check both bits.
>
> So very interesting! I gave this a spin with my monitors and it works fine.
>
> Vinod: Can you check the datasheet to see if the wrong bit is being used here?
Well the document I have does not list this register :(
I have asked Lontium folks about this register description, will update
if I hear back. Meanwhile we can get this patch tested with different
monitors.
Thanks
--
~Vinod
next prev parent reply other threads:[~2021-11-17 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 2:07 [PATCH] lontium-lt9611: check a different register bit for HDMI sensing Peter Collingbourne
2021-11-17 4:47 ` John Stultz
2021-11-17 5:10 ` Vinod Koul [this message]
[not found] ` <CA+_AqisE1yMvkPvRtp-8ZxMSpuwmfTrETkomfQHgSM-sEazuaQ@mail.gmail.com>
2021-11-17 5:09 ` Vinod Koul
2021-11-30 5:30 ` Vinod Koul
2021-11-30 12:17 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZSOzhygBRli1DVh@matsya \
--to=vkoul@kernel.org \
--cc=anibal.limon@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pcc@google.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox