From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Huang <tonyhuang.sunplus@gmail.com>
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, derek.kiernan@xilinx.com,
dragan.cvetic@xilinx.com, arnd@arndb.de, wells.lu@sunplus.com,
Tony Huang <tony.huang@sunplus.com>
Subject: Re: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021
Date: Wed, 17 Nov 2021 09:53:28 +0100 [thread overview]
Message-ID: <YZTDCG6bTjh7BoUH@kroah.com> (raw)
In-Reply-To: <1637131687-23000-3-git-send-email-tony.huang@sunplus.com>
On Wed, Nov 17, 2021 at 02:48:07PM +0800, Tony Huang wrote:
> Add iop driver for Sunplus SP7021
>
> Signed-off-by: Tony Huang <tony.huang@sunplus.com>
Along with everything that Arnd said, one more thing:
> +#define IOP_KDBG_INFO
> +#define IOP_FUNC_DEBUG
> +#define IOP_KDBG_ERR
> +#ifdef IOP_KDBG_INFO
> + #define FUNC_DEBUG() pr_info("K_IOP: %s(%d)\n", __func__, __LINE__)
> +#else
> + #define FUNC_DEBUG()
> +#endif
This should just be deleted entirely, use ftrace if you want to see what
your kernel driver is doing.
No single driver should have special debugging macros like this, use the
kernel-wide system please.
This driver code can get a lot smaller after you make these cleanups.
Also be sure to use scripts/checkpatch.pl to remove the issues that it
points out so we don't have to say the same thing.
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-17 8:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 6:48 [PATCH 0/2] Add iop driver for Sunplus SP7021 Tony Huang
2021-11-17 6:48 ` [PATCH 1/2] dt-binding: misc: Add iop yaml file " Tony Huang
2021-11-17 6:48 ` [PATCH 2/2] misc: Add iop driver " Tony Huang
2021-11-17 8:21 ` kernel test robot
2021-11-17 8:27 ` Arnd Bergmann
2021-11-19 2:27 ` Tony Huang 黃懷厚
2021-11-17 8:53 ` Greg KH [this message]
2021-11-17 9:17 ` Tony Huang 黃懷厚
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZTDCG6bTjh7BoUH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony.huang@sunplus.com \
--cc=tonyhuang.sunplus@gmail.com \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox