Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next

Madhavan Srinivasan
2021-11-17T08:31:02Z

On 11/7/21 01:02, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 03, 2021 at 04:52:15PM +0100, Thomas Richter escreveu:
>> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
>> broke the test case 27 (Sample parsing) on s390 on linux-next tree:
> Maddy,
>
> Can you please ack this one?

Sorry i missed this completely. My bad. Will check it and will reply.

Maddy

>
> - Arnaldo
>
>> # ./perf test -Fv 27
>> 27: Sample parsing
>> --- start ---
>> parsing failed for sample_type 0x800
>> ---- end ----
>> Sample parsing: FAILED!
>> #
>>
>> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
>> in above commit. Correct this define and the test case runs fine.
>>
>> Output After:
>> # ./perf test -Fv 27
>> 27: Sample parsing :
>> --- start ---
>> ---- end ----
>> Sample parsing: Ok
>> #
>>
>> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
>> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
>> ---
>> tools/perf/tests/sample-parsing.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
>> index c83a11514129..9c7af55b74db 100644
>> --- a/tools/perf/tests/sample-parsing.c
>> +++ b/tools/perf/tests/sample-parsing.c
>> @@ -36,7 +36,7 @@
>> * These are based on the input value (213) specified
>> * in branch_stack variable.
>> */
>> -#define BS_EXPECTED_BE 0xa00d000000000000
>> +#define BS_EXPECTED_BE 0xa000d00000000000
>> #define BS_EXPECTED_LE 0xd5000000
>> #define FLAG(s) s->branch_stack->entries[i].flags
>>
>> --
>> 2.25.1