From: Qian Cai <quic_qiancai@quicinc.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] software node: Skip duplicated software_node sysfs
Date: Wed, 17 Nov 2021 09:38:28 -0500 [thread overview]
Message-ID: <YZUT5EPqPiPy2iiy@fixkernel.fios-router.home> (raw)
In-Reply-To: <CAJZ5v0hjq+X=Gej072jwY2Uf4BgvqPHvHTON2p0Mszd5ntjjJA@mail.gmail.com>
On Tue, Nov 16, 2021 at 05:29:56PM +0100, Rafael J. Wysocki wrote:
> > Frist, fixes all dev->fwnode / dev.fwnode to use dev_fwnode(). This
> > could be a standalone tree-wide patchset going out to avoid
> > heavy-lifting later.
> >
> > Then, we can create another patchset on top. I have audited
> > "irq_domain" but not seen any "secondary" leakage. Struct
> > "cht_int33fe_data" does have some need to fix.
> >
> > Rename set_secondary_fwnode() to insert_secondary_fwnode(). Fix things
> > in drivers/base/core.c, swnode.c etc to use the new fwnode_head and
> > anything I can't think of right now.
> >
> > Since we will have multiple "software_node" (secondary fwnode:s) for a
> > single "device". What would be the usual way to deal with a
> > linked-list in the sysfs? I can think of just let "software_node"
> > become a directory to host a list of symlinks named from
> > swnode->id. Thoughts?
>
> Note that one pointer dereference in ACPI_COMPANION() is enough.
Rafael, we suppose to convert ACPI_COMPANION() to:
to_acpi_device_node(dev_fwnode())
since we will no longer has a dev->fwnode pointer anymore. Do you
suggest to keep that pointer but convert the "secondary" to a linked
list instead?
next prev parent reply other threads:[~2021-11-17 14:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 20:03 [RFC PATCH] software node: Skip duplicated software_node sysfs Qian Cai
[not found] ` <CAHp75VcrWPdR8EVGpcsniQedT0J4X700N7thFs6+srTP1MTgwQ@mail.gmail.com>
2021-11-02 8:28 ` Heikki Krogerus
2021-11-02 8:32 ` Heikki Krogerus
2021-11-02 14:17 ` Qian Cai
2021-11-02 19:44 ` Qian Cai
2021-11-02 20:20 ` Andy Shevchenko
2021-11-02 20:26 ` Andy Shevchenko
2021-11-05 18:47 ` Qian Cai
2021-11-05 19:39 ` Andy Shevchenko
2021-11-08 16:07 ` Qian Cai
2021-11-08 18:06 ` Andy Shevchenko
2021-11-09 4:43 ` Qian Cai
2021-11-09 15:23 ` Qian Cai
2021-11-16 3:54 ` Qian Cai
2021-11-16 16:29 ` Rafael J. Wysocki
2021-11-17 14:38 ` Qian Cai [this message]
2021-11-17 14:45 ` Rafael J. Wysocki
2021-11-17 16:18 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZUT5EPqPiPy2iiy@fixkernel.fios-router.home \
--to=quic_qiancai@quicinc.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox