public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Russ Weight <russell.h.weight@intel.com>
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, ardb@kernel.org,
	bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
	trix@redhat.com, lgoncalv@redhat.com, yilun.xu@intel.com,
	hao.wu@intel.com, matthew.gerlach@intel.com
Subject: Re: [RFC PATCH 1/5] firmware: Create firmware upload framework
Date: Wed, 17 Nov 2021 16:15:06 +0100	[thread overview]
Message-ID: <YZUceupQe67KYJyf@kroah.com> (raw)
In-Reply-To: <20211111011345.25049-2-russell.h.weight@intel.com>

On Wed, Nov 10, 2021 at 05:13:41PM -0800, Russ Weight wrote:
> The Firmware Upload class driver provides a common API for uploading
> firmware files to devices.

That is exactly what the existing firmware api in the kernel is supposed
to be accomplishing.

If it is not doing what you need it to do, then you need to document the
heck out of why it is not, and why you need a different api for this.  I
do not see that here in this changelog at all :(

thanks,

greg k-h

  reply	other threads:[~2021-11-17 15:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11  1:13 [RFC PATCH 0/5] Firmware Upload Framework Russ Weight
2021-11-11  1:13 ` [RFC PATCH 1/5] firmware: Create firmware upload framework Russ Weight
2021-11-17 15:15   ` Greg KH [this message]
2021-11-17 18:00     ` Russ Weight
2021-11-17 18:18       ` Greg KH
2021-11-17 18:47         ` Russ Weight
2021-11-17 18:54           ` Greg KH
2021-11-17 20:02             ` Russ Weight
2021-11-11  1:13 ` [RFC PATCH 2/5] firmware: upload: Enable firmware uploads Russ Weight
2021-11-17 19:29   ` Bjorn Andersson
2021-11-11  1:13 ` [RFC PATCH 3/5] firmware: upload: Signal eventfd when complete Russ Weight
2021-11-11  1:13 ` [RFC PATCH 4/5] firmware: upload: Add status ioctl Russ Weight
2021-11-11  1:13 ` [RFC PATCH 5/5] firmware: upload: Enable cancel of firmware upload Russ Weight
2021-11-15 13:57 ` [RFC PATCH 0/5] Firmware Upload Framework Tom Rix
2021-11-17 19:20   ` Bjorn Andersson
2021-12-09 15:15     ` Tom Rix
2021-12-09 15:34       ` Greg KH
2021-12-09 18:55         ` Tom Rix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZUceupQe67KYJyf@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ardb@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=cristian.marussi@arm.com \
    --cc=hao.wu@intel.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@intel.com \
    --cc=russell.h.weight@intel.com \
    --cc=sudeep.holla@arm.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox