public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	dri-devel@lists.freedesktop.org,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"Pekka Paalanen" <pekka.paalanen@collabora.com>
Subject: Re: [PATCH v5 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem
Date: Fri, 19 Nov 2021 12:08:49 +0100	[thread overview]
Message-ID: <YZeFwcuP1cu9MOZu@kroah.com> (raw)
In-Reply-To: <b63cbd1d-4669-422d-0908-0eec1981caa6@redhat.com>

On Fri, Nov 19, 2021 at 11:20:13AM +0100, Javier Martinez Canillas wrote:
> [ adding gregkh to Cc list for drivers/video/console ]
> 
> On 11/12/21 14:32, Javier Martinez Canillas wrote:
> > The "nomodeset" kernel cmdline parameter is handled by the vgacon driver
> > but the exported vgacon_text_force() symbol is only used by DRM drivers.
> > 
> > It makes much more sense for the parameter logic to be in the subsystem
> > of the drivers that are making use of it.
> > 
> > Let's move the vgacon_text_force() function and related logic to the DRM
> > subsystem. While doing that, rename it to drm_firmware_drivers_only() and
> > make it return true if "nomodeset" was used and false otherwise. This is
> > a better description of the condition that the drivers are testing for.
> > 
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> > Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>
> > ---
> >
> 
> Greg, could I please get your ack for this patch ?

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

  reply	other threads:[~2021-11-19 11:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 13:32 [PATCH v5 0/6] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 1/6] drm: Don't print messages if drivers are disabled due nomodeset Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 2/6] drm/vboxvideo: Drop CONFIG_VGA_CONSOLE guard to call vgacon_text_force() Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem Javier Martinez Canillas
2021-11-19 10:20   ` Javier Martinez Canillas
2021-11-19 11:08     ` Greg Kroah-Hartman [this message]
2021-11-12 13:32 ` [PATCH v5 4/6] drm: Decouple nomodeset from CONFIG_VGA_CONSOLE Javier Martinez Canillas
2021-11-12 14:05   ` Jani Nikula
2021-11-12 13:32 ` [PATCH v5 5/6] Documentation/admin-guide: Document nomodeset kernel parameter Javier Martinez Canillas
2021-11-12 13:32 ` [PATCH v5 6/6] drm: Make the nomodeset message less sensational Javier Martinez Canillas
2021-11-27 13:06 ` [PATCH v5 0/6] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZeFwcuP1cu9MOZu@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=pbrobinson@gmail.com \
    --cc=pekka.paalanen@collabora.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox