From: Vinod Koul <vkoul@kernel.org>
To: Tim Gardner <tim.gardner@canonical.com>
Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2][linux-next] dmaengine: dw-axi-dmac: Fix uninitialized variable in axi_chan_block_xfer_start()
Date: Mon, 22 Nov 2021 11:22:39 +0530 [thread overview]
Message-ID: <YZswJ7eZO2LdJ3ST@matsya> (raw)
In-Reply-To: <20211025181656.31658-1-tim.gardner@canonical.com>
On 25-10-21, 12:16, Tim Gardner wrote:
> Coverity complains of an uninitialized variable:
>
> 5. uninit_use_in_call: Using uninitialized value config.dst_per when calling axi_chan_config_write. [show details]
> 6. uninit_use_in_call: Using uninitialized value config.hs_sel_src when calling axi_chan_config_write. [show details]
> CID 121164 (#1-3 of 3): Uninitialized scalar variable (UNINIT)
> 7. uninit_use_in_call: Using uninitialized value config.src_per when calling axi_chan_config_write. [show details]
> 418 axi_chan_config_write(chan, &config);
>
> Fix this by initializing the structure to 0 which should at least be benign in axi_chan_config_write(). Also fix
> what looks like a cut-n-paste error when initializing config.hs_sel_dst.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-11-22 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 19:07 [PATCH][linux-next] dmaengine: dw-axi-dmac: Fix uninitialized variable in axi_chan_block_xfer_start() Tim Gardner
2021-10-25 5:33 ` Vinod Koul
2021-10-25 18:16 ` [PATCH v2][linux-next] " Tim Gardner
2021-11-22 5:52 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZswJ7eZO2LdJ3ST@matsya \
--to=vkoul@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox