From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29986C433F5 for ; Mon, 22 Nov 2021 12:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239389AbhKVMgn (ORCPT ); Mon, 22 Nov 2021 07:36:43 -0500 Received: from mga03.intel.com ([134.134.136.65]:60414 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234638AbhKVMgl (ORCPT ); Mon, 22 Nov 2021 07:36:41 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="234719872" X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="234719872" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 04:33:34 -0800 X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="537859733" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 04:33:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mp8Vl-009QnG-3a; Mon, 22 Nov 2021 14:33:29 +0200 Date: Mon, 22 Nov 2021 14:33:28 +0200 From: Andy Shevchenko To: Wolfram Sang , "open list:GPIO SUBSYSTEM" , Linux-Renesas , Linus Walleij , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] gpio: add sloppy logic analyzer using polling Message-ID: References: <20210918083307.3195-1-wsa+renesas@sang-engineering.com> <20210918083307.3195-2-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 22, 2021 at 01:19:20PM +0100, Wolfram Sang wrote: ... > > > > > + if (ret < 0) { > > > > > > > > > + dev_err(dev, "error naming the GPIOs: %d\n", ret); > > > > > + return ret; > > > > > + } > > > > > > > > Perhaps > > > > > > > > return dev_err_probe() ? > > > > > > Reading strings from DT can be deferred? I don't think so. > > > > There is a new development, i.e. the documentation for dev_err_probe() > > is going to be amended to allow this. But I can't quickly find a patch > > in mailing list with the related discussion. > > I still don't get this one, so if there is new development and you have > a pointer, I'd be glad to hear about it. Otherwise we can fix it > incrementally later. See 7065f92255bb ("driver core: Clarify that dev_err_probe() is OK even w/out -EPROBE_DEFER"). -- With Best Regards, Andy Shevchenko