From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A9A6C433F5 for ; Mon, 22 Nov 2021 13:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236595AbhKVNTR (ORCPT ); Mon, 22 Nov 2021 08:19:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:23401 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231697AbhKVNTO (ORCPT ); Mon, 22 Nov 2021 08:19:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637586967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+7y/Bofw8lWfpgLxh6z7UjG0SZVGiKjt0Kj8TgkRr9o=; b=YIZewtdyFYriZLtYDEQOzgazBRJx82r20hY9JLsdGcFkxjUuyGiN9CZ7RulQ3RC6QQB/ps QDeWaWHOZWUPobihnERSY8zL0T8Ye3PYFWSv1zerKttiXOoYcwEoMSjgonYTulwI5gQ5R5 jSN9xw6d33BpkC2p6gEBAkQFPgy5KB4= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-96-hCPbXs5UMq2zU1TkhMFGGg-1; Mon, 22 Nov 2021 08:16:06 -0500 X-MC-Unique: hCPbXs5UMq2zU1TkhMFGGg-1 Received: by mail-qk1-f197.google.com with SMTP id q5-20020a05620a0d8500b0045edb4779dbso14849525qkl.2 for ; Mon, 22 Nov 2021 05:16:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+7y/Bofw8lWfpgLxh6z7UjG0SZVGiKjt0Kj8TgkRr9o=; b=IzKli6i8StcfRCVjauxrEhHZPTh5xN0X7D5LcoH0Fhxy1kCdPE4CCe+SUWuQGvOmzu rxX2TcUrd0QsG1M9OnuIA8UhaWouh+SS7kLtGvr2XjDYhwMTr/ts3anaqgyFi0EteU8+ i9RfPANh30X+MUp8BIPAzHWh5hPqv4IGInESuZT43sk7ZiKcauLHB90nCl0MriG8q4pG Csdf71S4lwaa9dJgztZcrIKRTsI3oarDAxPF6S5qIkl4qtVqNX3f23nhu8plJgartqbN dMXS1Z2m1EIs7kMlsz6TSz/r6lv3zJgimTUr1w/s8F4EG5rB/au2ai3XUcGjv/7JDkUE 7TPw== X-Gm-Message-State: AOAM532bVu8euiGDcB11eMejp0LCQDUSmbtaSfD+gpYXRgeXO0rSiO0k vW+C6jRt53rDgWch7qbQgzltty8igBNYXsV6SZgu5s7wW7NZlbEvk3FtYVLAUN1g+ABzlkDpLby dTDVQ2qkrktwae4A1qPOlUIw3 X-Received: by 2002:ac8:5703:: with SMTP id 3mr31944932qtw.113.1637586965168; Mon, 22 Nov 2021 05:16:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJz06CRM2dc04nwBmJ2HYB4x+ZHSkk++cA8qm/5otconkwhWCeYC5hIOrUa+nFBfPyvJsVXUrw== X-Received: by 2002:ac8:5703:: with SMTP id 3mr31944895qtw.113.1637586964900; Mon, 22 Nov 2021 05:16:04 -0800 (PST) Received: from krava (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id o17sm4492865qtv.30.2021.11.22.05.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 05:16:04 -0800 (PST) Date: Mon, 22 Nov 2021 14:16:00 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Sohaib Mohamed , Song Liu , Jiri Olsa , Namhyung Kim , Ian Rogers , Linux Kernel Mailing List Subject: Re: 'perf stat --bpf-counters test' failures Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 22, 2021 at 10:08:00AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Nov 19, 2021 at 03:08:44PM +0100, Jiri Olsa escreveu: > > On Fri, Nov 19, 2021 at 09:28:15AM -0300, Arnaldo Carvalho de Melo wrote: > > > > > > After I updated to fedora 35 I started seeing the errors below, > > > it may well not be related to that, maybe something on libbpf, haven't > > > investigated, have you seen this? > > > > yep, it seems the perf bench is broken so the counts won't correlated > > if I revert this one: > > 92723ea0f11d perf bench: Fix two memory leaks detected with ASan > > > > it works for me again.. it seems to break -t option > > > > Sohaib, could you please check on that? > > > > [root@dell-r440-01 perf]# ./perf bench sched messaging -g 1 -l 100 -t > > # Running 'sched/messaging' benchmark: > > RRRperf: CLIENT: ready write: Bad file descriptor > > Rperf: SENDER: write: Bad file descriptor > > I'm reverting that patch, with you as the author of the revert, ok? sure, thanks jirka > > - Arnaldo > > > thanks, > > jirka > > > > > > > > ⬢[acme@toolbox perf]$ perf -vv > > > perf version 5.16.rc1.gfa2b5229b222 > > > dwarf: [ on ] # HAVE_DWARF_SUPPORT > > > dwarf_getlocations: [ on ] # HAVE_DWARF_GETLOCATIONS_SUPPORT > > > glibc: [ on ] # HAVE_GLIBC_SUPPORT > > > syscall_table: [ on ] # HAVE_SYSCALL_TABLE_SUPPORT > > > libbfd: [ on ] # HAVE_LIBBFD_SUPPORT > > > libelf: [ on ] # HAVE_LIBELF_SUPPORT > > > libnuma: [ on ] # HAVE_LIBNUMA_SUPPORT > > > numa_num_possible_cpus: [ on ] # HAVE_LIBNUMA_SUPPORT > > > libperl: [ on ] # HAVE_LIBPERL_SUPPORT > > > libpython: [ on ] # HAVE_LIBPYTHON_SUPPORT > > > libslang: [ on ] # HAVE_SLANG_SUPPORT > > > libcrypto: [ on ] # HAVE_LIBCRYPTO_SUPPORT > > > libunwind: [ on ] # HAVE_LIBUNWIND_SUPPORT > > > libdw-dwarf-unwind: [ on ] # HAVE_DWARF_SUPPORT > > > zlib: [ on ] # HAVE_ZLIB_SUPPORT > > > lzma: [ on ] # HAVE_LZMA_SUPPORT > > > get_cpuid: [ on ] # HAVE_AUXTRACE_SUPPORT > > > bpf: [ on ] # HAVE_LIBBPF_SUPPORT > > > aio: [ on ] # HAVE_AIO_SUPPORT > > > zstd: [ on ] # HAVE_ZSTD_SUPPORT > > > libpfm4: [ OFF ] # HAVE_LIBPFM > > > ⬢[acme@toolbox perf]$ > > > > > > This is with what I have now in my perf/urgent branch, the csets there > > > aren't related: > > > > > > ⬢[acme@toolbox perf]$ git log --oneline torvalds/master.. > > > b194c9cd09dd98af (HEAD -> perf/urgent, quaco/perf/urgent, acme/tmp.perf/urgent, acme/perf/urgent) perf evsel: Fix memory leaks relating to unit > > > d9fc706108c15f8b perf report: Fix memory leaks around perf_tip() > > > 0ca1f534a776cc7d perf hist: Fix memory leak of a perf_hpp_fmt > > > 8b8dcc3720d57d88 tools headers UAPI: Sync MIPS syscall table file changed by new futex_waitv syscall > > > e8c04ea0fef5731d tools build: Fix removal of feature-sync-compare-and-swap feature detection > > > 9e1a8d9f683260d5 perf inject: Fix ARM SPE handling > > > 92723ea0f11d9249 perf bench: Fix two memory leaks detected with ASan > > > cb5a63feae2d963c perf test sample-parsing: Fix branch_stack entry endianness check > > > 162b944598344fd7 tools headers UAPI: Sync x86's asm/kvm.h with the kernel sources > > > db4b284029099224 perf sort: Fix the 'p_stage_cyc' sort key behavior > > > 4d03c75363eeca86 perf sort: Fix the 'ins_lat' sort key behavior > > > 784e8adda4cdb3e2 perf sort: Fix the 'weight' sort key behavior > > > 70f9c9b2df1dd12c perf tools: Set COMPAT_NEED_REALLOCARRAY for CONFIG_AUXTRACE=1 > > > ccb05590c4325ce5 perf tests wp: Remove unused functions on s390 > > > 346e91998cba46b6 tools headers UAPI: Sync linux/kvm.h with the kernel sources > > > b075c1d81e7d0e96 tools headers cpufeatures: Sync with the kernel sources > > > ⬢[acme@toolbox perf]$ > > > > > > - Arnaldo > > > > > > [acme@quaco perf]$ uname -a > > > Linux quaco 5.14.17-301.fc35.x86_64 #1 SMP Mon Nov 8 13:57:43 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux > > > > > > 91: perf stat --bpf-counters test :RRRRRRRRRRRRR FAILED! > > > 92: Check Arm CoreSight trace data recording and synthesized samples: Skip > > > 93: Check Arm SPE trace data recording and synthesized samples : Skip > > > 94: Check open filename arg using perf trace + vfs_getname : Ok > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRRRRRR FAILED! > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRRRRRR FAILED! > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRRRRR FAILED! > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRRRRRRRRRRR Ok > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRR FAILED! > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRRRR Ok > > > [root@quaco ~]# perf test 91 > > > 91: perf stat --bpf-counters test :RRRRRRRRRRRRRRR Ok > > > [root@quaco ~]# uname -a > > > Linux quaco 5.14.17-301.fc35.x86_64 #1 SMP Mon Nov 8 13:57:43 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux > > > [root@quaco ~]# set -o vi > > > [root@quaco ~]# perf test -v 91 > > > 91: perf stat --bpf-counters test : > > > --- start --- > > > test child forked, pid 30079 > > > RRRRRRRRRRRRRRRRRThe difference between 31599305 and 36265639 are greater than 10%. > > > test child finished with -1 > > > ---- end ---- > > > perf stat --bpf-counters test: FAILED! > > > [root@quaco ~]# perf test -v 91 > > > 91: perf stat --bpf-counters test : > > > --- start --- > > > test child forked, pid 30170 > > > RRRRRRRRRRRRRRRRRRRRRRRRThe difference between 33311934 and 36973889 are greater than 10%. > > > test child finished with -1 > > > ---- end ---- > > > perf stat --bpf-counters test: FAILED! > > > [root@quaco ~]# perf test -v 91 > > > 91: perf stat --bpf-counters test : > > > --- start --- > > > test child forked, pid 30257 > > > RRRRRRRRRRRRRRRRRThe difference between 31420157 and 36680527 are greater than 10%. > > > test child finished with -1 > > > ---- end ---- > > > perf stat --bpf-counters test: FAILED! > > > [root@quaco ~]# perf test -v 91 > > > 91: perf stat --bpf-counters test : > > > --- start --- > > > test child forked, pid 30341 > > > RRRRRRRRRRRRRRRRRRRThe difference between 32451720 and 36750342 are greater than 10%. > > > test child finished with -1 > > > ---- end ---- > > > perf stat --bpf-counters test: FAILED! > > > [root@quaco ~]# perf test -v 91 > > > 91: perf stat --bpf-counters test : > > > --- start --- > > > test child forked, pid 30433 > > > RRRRRRRRRRRRRRRRRRtest child finished with 0 > > > ---- end ---- > > > perf stat --bpf-counters test: Ok > > > [root@quaco ~]# > > > > > -- > > - Arnaldo >