Re: [PATCH 0/5] printk/console: Registration code cleanup - part 1

Petr Mladek
2021-12-06T13:54:37Z

On Mon 2021-11-22 14:26:44, Petr Mladek wrote:
> The console registration code has several twists that are hard to follow.
> It is result of various features added over the last few decades.
>
> I have already spent many days to understand all the effects and
> the desired behavior. I am always scared to touch the console registration
> code even after years working as printk maintainer.
>
> There were several changes in the code that had to be reverted because
> they caused regression, for example:
>
> + commit dac8bbbae1d0ccba96402 ("Revert "printk: fix double printing
> with earlycon")
>
> + commit c6c7d83b9c9e6a8b3e6d ("Revert "console: don't prefer first
> registered if DT specifies stdout-path")
>
>
> This patchset removes the most tricky twists from my POV. I have worked
> on it when time permitted since January. I have spent most of the time
> writing the commit message, understanding, and explaining the effects.
> I am not sure if I succeeded but it is time to send this.
>
>
> Behavior change:
>
> There is one behavior change caused by 4th patch. I consider it bug fix.
> It should be acceptable. See the commit message for more details.

I am afraid that the patchset is not easy to review. I decided to help
a bit and give it a spin in linux-next.

The patchset has been committed into printk/linux.git, branch
console-registration-cleanup. It should appear in linux-next
during the next respin.

I am going to take it back when anyone reports any problem that
can't be fixed easily.

Any feedback is still appreciated.

Best Regards,
Petr