From: Eric Biggers <ebiggers@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Benjamin LaHaise <bcrl@kvack.org>
Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, Ramji Jiyani <ramjiyani@google.com>,
Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Martijn Coenen <maco@android.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/5] binder: use wake_up_pollfree()
Date: Tue, 7 Dec 2021 11:11:54 -0800 [thread overview]
Message-ID: <Ya+x+p3YR1PtbD7O@sol.localdomain> (raw)
In-Reply-To: <20211207095726.169766-3-ebiggers@kernel.org>
On Tue, Dec 07, 2021 at 01:57:23AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> wake_up_poll() uses nr_exclusive=1, so it's not guaranteed to wake up
> all non-exclusive waiters. Yet, POLLFREE *must* wake up all waiters.
This is supposed to say "all exclusive waiters". Same in patch 3.
- Eric
next prev parent reply other threads:[~2021-12-07 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 9:57 [PATCH v2 0/5] aio: fix use-after-free and missing wakeups Eric Biggers
2021-12-07 9:57 ` [PATCH v2 1/5] wait: add wake_up_pollfree() Eric Biggers
2021-12-07 9:57 ` [PATCH v2 2/5] binder: use wake_up_pollfree() Eric Biggers
2021-12-07 19:11 ` Eric Biggers [this message]
2021-12-07 9:57 ` [PATCH v2 3/5] signalfd: " Eric Biggers
2021-12-07 9:57 ` [PATCH v2 4/5] aio: keep poll requests on waitqueue until completed Eric Biggers
2021-12-07 9:57 ` [PATCH v2 5/5] aio: fix use-after-free due to missing POLLFREE handling Eric Biggers
2021-12-07 11:17 ` [PATCH v2 0/5] aio: fix use-after-free and missing wakeups Christoph Hellwig
2021-12-07 19:10 ` Eric Biggers
2021-12-07 23:24 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya+x+p3YR1PtbD7O@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=hch@lst.de \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=oleg@redhat.com \
--cc=ramjiyani@google.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox