From: Greg KH <gregkh@linuxfoundation.org>
To: Kai Ye <yekai13@huawei.com>
Cc: linux-accelerators@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
zhangfei.gao@linaro.org, wangzhou1@hisilicon.com
Subject: Re: [PATCH v2] uacce: use sysfs_emit instead of sprintf
Date: Mon, 6 Dec 2021 08:25:20 +0100 [thread overview]
Message-ID: <Ya264Nd3nfuHeZF0@kroah.com> (raw)
In-Reply-To: <20211206070943.45971-1-yekai13@huawei.com>
On Mon, Dec 06, 2021 at 03:09:43PM +0800, Kai Ye wrote:
> Use the sysfs_emit to replace sprintf. sprintf may cause
> output defect in sysfs content, it is better to use new
> added sysfs_emit function which knows the size of the
> temporary buffer.
For these calls you have replaced, there is no real reason to change as
it is obvious that the buffer is big enough. So there is no "may cause
output defect" here.
Also, feel free to use the full 72 columns for your changelog text.
>
> Signed-off-by: Kai Ye <yekai13@huawei.com>
>
> changes v1->v2:
> modfiy the comments.
> ---
As per the documentation, the "changes..." lines go below the --- line
so that git will remove them automatically.
Please fix up and resend a v3.
thanks,
greg k-h
prev parent reply other threads:[~2021-12-06 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 7:09 [PATCH v2] uacce: use sysfs_emit instead of sprintf Kai Ye
2021-12-06 7:18 ` Joe Perches
2021-12-06 7:25 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya264Nd3nfuHeZF0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yekai13@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox