From: Andrew Lunn <andrew@lunn.ch>
To: Apeksha Gupta <apeksha.gupta@nxp.com>
Cc: qiangqing.zhang@nxp.com, netdev@vger.kernel.org, kuba@kernel.org,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-devel@linux.nxdi.nxp.com, LnxRevLi@nxp.com,
sachin.saxena@nxp.com, hemant.agrawal@nxp.com
Subject: Re: [PATCH v2 0/3] drivers/net: split FEC driver
Date: Mon, 6 Dec 2021 14:32:37 +0100 [thread overview]
Message-ID: <Ya4Q9aysfYwV35MO@lunn.ch> (raw)
In-Reply-To: <20211206045536.8690-1-apeksha.gupta@nxp.com>
On Mon, Dec 06, 2021 at 10:25:33AM +0530, Apeksha Gupta wrote:
> This patch series is to restructure the FEC (Fast Ethernet Controller)
> driver. All PHY functionality moved from fec_main.c to separate files
> fec_phy.h and fec_phy.c. By these changes FEC driver become more
> flexible to work with other PHY drivers whenever required in future.
The MAC driver has little to do with the PHY driver. All PHY driver
details are in the actual PHY driver and phylib. At minimum we need to
see these other PHY driver changes, so you can justify this change.
What i think you are trying to do is sneak in the changes you need for
DPDK. Please don't so that. Just implement XDP.
NACK
Andrew
prev parent reply other threads:[~2021-12-06 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 4:55 [PATCH v2 0/3] drivers/net: split FEC driver Apeksha Gupta
2021-12-06 4:55 ` [PATCH v2 1/3] fec_phy: add new PHY file Apeksha Gupta
2021-12-06 4:55 ` [PATCH v2 2/3] fec_main: removed PHY functions Apeksha Gupta
2021-12-06 4:55 ` [PATCH v2 3/3] MAINTAINERS: added new files Apeksha Gupta
2021-12-06 13:32 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya4Q9aysfYwV35MO@lunn.ch \
--to=andrew@lunn.ch \
--cc=LnxRevLi@nxp.com \
--cc=apeksha.gupta@nxp.com \
--cc=arnd@arndb.de \
--cc=hemant.agrawal@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-devel@linux.nxdi.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=sachin.saxena@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox