From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Donnefort <vincent.donnefort@arm.com>
Cc: mingo@redhat.com, vincent.guittot@linaro.org,
linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
valentin.schneider@arm.com
Subject: Re: [PATCH v2 1/2] sched/fair: Fix asym_fits_capacity() task_util type
Date: Mon, 6 Dec 2021 16:20:04 +0100 [thread overview]
Message-ID: <Ya4qJHxUbKMzl04d@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20211118141411.2623521-1-vincent.donnefort@arm.com>
On Thu, Nov 18, 2021 at 02:14:10PM +0000, Vincent Donnefort wrote:
> task_util is an unsigned long value, compared with a CPU capacity which is
> unsigned long as well. There's no need for an intermediate implicit int
> cast.
>
> Fixes: b4c9c9f15649 ("sched/fair: Prefer prev cpu in asymmetric wakeup path")
Do either of these patches actually *fix* anything? Afaict they're an
absolute no-op, even in terms of code-gen due to the promotion rules.
Yes, its arguably nicer to not rely on those implicit promotions etc..
but I don't think this warrants a Fixes tag or even being split in two
patches.
Hmm?
next prev parent reply other threads:[~2021-12-06 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 14:14 [PATCH v2 1/2] sched/fair: Fix asym_fits_capacity() task_util type Vincent Donnefort
2021-11-18 14:14 ` [PATCH v2 2/2] sched/fair: Fix task_fits_capacity() capacity type Vincent Donnefort
2021-11-23 8:38 ` Vincent Guittot
2021-12-06 15:20 ` Peter Zijlstra [this message]
2021-12-07 9:48 ` [PATCH v2 1/2] sched/fair: Fix asym_fits_capacity() task_util type Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya4qJHxUbKMzl04d@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox