From: Patrick Williams <patrick@stwcx.xyz>
To: Howard Chiu <howard10703049@gmail.com>
Cc: arnd@arndb.de, olof@lixom.net, soc@kernel.org,
robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Howard Chiu <howard.chiu@quantatw.com>
Subject: Re: [PATCH v6] ARM: dts: aspeed: Adding Facebook Bletchley BMC
Date: Mon, 6 Dec 2021 15:25:19 -0600 [thread overview]
Message-ID: <Ya5/v+VhOM9o9BtQ@heinlein> (raw)
In-Reply-To: <20211201033738.121846-1-howard.chiu@quantatw.com>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Wed, Dec 01, 2021 at 11:37:38AM +0800, Howard Chiu wrote:
> Initial introduction of Facebook Bletchley equipped with
> Aspeed 2600 BMC SoC.
>
> Signed-off-by: Howard Chiu <howard.chiu@quantatw.com>
>
...
> Change since v2:
> - Remove uart5 workaround
> - Remove gpio nodes of pca9552/pca9539
> - Modify gpio-line-name of led/power/presence pins with openbmc pattern
A number of the GPIOs do not have defined openbmc patterns for them yet. The
names you have chosen are ok for now, but we will be changing them as we refine
development of this machine further.
> + gpio-line-names =
> + "SLED0_MS_DETECT1","SLED0_VBUS_BMC_EN","SLED0_INA230_ALERT","SLED0_P12V_STBY_ALERT",
> + "SLED0_SSD_ALERT","SLED0_MS_DETECT0","SLED0_RST_CCG5","SLED0_FUSB302_INT",
> + "SLED0_MD_STBY_RESET","SLED0_MD_IOEXP_EN_FAULT","SLED0_MD_DIR","SLED0_MD_DECAY",
> + "SLED0_MD_MODE1","SLED0_MD_MODE2","SLED0_MD_MODE3","power-host0";
Such as these...
> --
> 2.25.1
>
Otherwise,
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-06 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 3:37 [PATCH v6] ARM: dts: aspeed: Adding Facebook Bletchley BMC Howard Chiu
2021-12-02 6:06 ` Joel Stanley
2021-12-06 21:25 ` Patrick Williams [this message]
2021-12-06 22:51 ` Joel Stanley
2021-12-07 2:53 ` Howard Chiu (邱冠睿)
2021-12-07 3:29 ` Joel Stanley
2021-12-07 6:34 ` Howard Chiu (邱冠睿)
2021-12-07 6:37 ` Joel Stanley
2021-12-07 6:42 ` Howard Chiu (邱冠睿)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5/v+VhOM9o9BtQ@heinlein \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=howard.chiu@quantatw.com \
--cc=howard10703049@gmail.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox