Re: [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC

Satya Priya Kakitapalli (Temp)
2021-12-20T10:44:40Z

On 12/6/2021 8:39 PM, Mark Brown wrote:
> On Mon, Dec 06, 2021 at 08:13:57PM +0530, Satya Priya Kakitapalli (Temp) wrote:
>> On 11/25/2021 9:15 PM, Mark Brown wrote:
>>> On Fri, Nov 19, 2021 at 03:12:31PM +0530, Satya Priya wrote:
>>>> + child_node = of_get_child_by_name(parent_node, reg->name);
>>>> + if (!child_node) {
>>>> + dev_err(dev, "child node %s not found\n", reg->name);
>>>> + return -ENODEV;
>>>> + }
>>> This could be pulled out of the array.
>> Not sure what you meant here. could you elaborate a bit?
> Why is this in every iteration of the loop?

Getting the child node here is not required anymore. This got carried
from previous versions, I'll remove this.