Re: [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator bindings

Mark Brown
2021-11-25T15:26:27Z

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On Fri, Nov 19, 2021 at 03:12:29PM +0530, Satya Priya wrote:

> +properties:
> + compatible:
> + const: qcom,pm8008-regulators

Why are we adding a separate compatible for this when we already know
that this is a pm8008 based on the parent?

> + vdd_l1_l2-supply:
> + description: Input supply phandle of ldo1 and ldo2 regulators.

These supply nodes should be chip level, they're going into the chip and
in general the expectation is that you should be able to describe the
supplies going into a device without worrying about how or if any
particular OS splits things up.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]