Re: [PATCH V4 4/6] regulator: Add a regulator driver for the PM8008 PMIC

Mark Brown
2021-12-06T15:15:51Z

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

On Mon, Dec 06, 2021 at 08:13:57PM +0530, Satya Priya Kakitapalli (Temp) wrote:
> On 11/25/2021 9:15 PM, Mark Brown wrote:
> > On Fri, Nov 19, 2021 at 03:12:31PM +0530, Satya Priya wrote:

> > > + child_node = of_get_child_by_name(parent_node, reg->name);
> > > + if (!child_node) {
> > > + dev_err(dev, "child node %s not found\n", reg->name);
> > > + return -ENODEV;
> > > + }

> > This could be pulled out of the array.

> Not sure what you meant here. could you elaborate a bit?

Why is this in every iteration of the loop?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]