From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH] remoteproc: Fix remaining wrong return formatting in documentation
Date: Mon, 6 Dec 2021 14:11:29 -0600 [thread overview]
Message-ID: <Ya5ucVAGf/qFpVbx@builder.lan> (raw)
In-Reply-To: <20211206191858.10741-1-arnaud.pouliquen@foss.st.com>
On Mon 06 Dec 13:18 CST 2021, Arnaud Pouliquen wrote:
> kernel documentation specification:
> "The return value, if any, should be described in a dedicated section
> named Return."
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Thanks,
Bjorn
> ---
> drivers/remoteproc/mtk_scp_ipi.c | 4 ++--
> drivers/remoteproc/st_slim_rproc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c
> index 6dc955ecab80..00f041ebcde6 100644
> --- a/drivers/remoteproc/mtk_scp_ipi.c
> +++ b/drivers/remoteproc/mtk_scp_ipi.c
> @@ -23,7 +23,7 @@
> *
> * Register an ipi function to receive ipi interrupt from SCP.
> *
> - * Returns 0 if ipi registers successfully, -error on error.
> + * Return: 0 if ipi registers successfully, -error on error.
> */
> int scp_ipi_register(struct mtk_scp *scp,
> u32 id,
> @@ -150,7 +150,7 @@ EXPORT_SYMBOL_GPL(scp_ipi_unlock);
> * When the processing completes, IPI handler registered
> * by scp_ipi_register will be called in interrupt context.
> *
> - * Returns 0 if sending data successfully, -error on error.
> + * Return: 0 if sending data successfully, -error on error.
> **/
> int scp_ipi_send(struct mtk_scp *scp, u32 id, void *buf, unsigned int len,
> unsigned int wait)
> diff --git a/drivers/remoteproc/st_slim_rproc.c b/drivers/remoteproc/st_slim_rproc.c
> index 22096adc1ad3..4ed9467897e5 100644
> --- a/drivers/remoteproc/st_slim_rproc.c
> +++ b/drivers/remoteproc/st_slim_rproc.c
> @@ -216,7 +216,7 @@ static const struct rproc_ops slim_rproc_ops = {
> * obtains and enables any clocks required by the SLIM core and also
> * ioremaps the various IO.
> *
> - * Returns st_slim_rproc pointer or PTR_ERR() on error.
> + * Return: st_slim_rproc pointer or PTR_ERR() on error.
> */
>
> struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev,
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-12-06 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 19:18 [PATCH] remoteproc: Fix remaining wrong return formatting in documentation Arnaud Pouliquen
2021-12-06 20:11 ` Bjorn Andersson [this message]
2021-12-08 17:27 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5ucVAGf/qFpVbx@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox