From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: lianzhi chang <changlianzhi@uniontech.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, andriy.shevchenko@linux.intel.com,
dan.carpenter@oracle.com, lkp@intel.com, 282827961@qq.com
Subject: Re: [PATCH v19] tty: Fix the keyboard led light display problem
Date: Mon, 6 Dec 2021 23:22:35 -0800 [thread overview]
Message-ID: <Ya8Lu1lo72w7JAud@google.com> (raw)
In-Reply-To: <20211201012235.9472-1-changlianzhi@uniontech.com>
On Wed, Dec 01, 2021 at 09:22:35AM +0800, lianzhi chang wrote:
> + if (kb->kbdmode != VC_RAW &&
> + kb->kbdmode != VC_MEDIUMRAW &&
> + kb->kbdmode != VC_OFF) {
> + vt_switch = true;
> + set_leds();
> + }
As I mentioned earlier, please do this unconditionally.
Thanks.
--
Dmitry
prev parent reply other threads:[~2021-12-07 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 1:22 [PATCH v19] tty: Fix the keyboard led light display problem lianzhi chang
2021-12-07 7:22 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya8Lu1lo72w7JAud@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=282827961@qq.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changlianzhi@uniontech.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox