Re: [PATCH 10/15] arm64: dts: qcom: sm8450: add interconnect nodes

Vinod Koul
2021-12-06T06:13:03Z

On 01-12-21, 16:20, Konrad Dybcio wrote:
>
> On 01.12.2021 08:29, Vinod Koul wrote:
> > And the various interconnect nodes found in SM8450 SoC and use it for
> > UFS controller.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/sm8450.dtsi | 80 ++++++++++++++++++++++++++++
> > 1 file changed, 80 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > index 75827bbfb3ad..4c7cdcea33fa 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > @@ -6,6 +6,7 @@
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > #include <dt-bindings/clock/qcom,gcc-sm8450.h>
> > #include <dt-bindings/clock/qcom,rpmh.h>
> > +#include <dt-bindings/interconnect/qcom,sm8450.h>
> > #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> >
> > / {
> > @@ -573,6 +574,61 @@ uart7: serial@99c000 {
> > };
> > };
> >
> > + config_noc: interconnect@1500000 {
> > + compatible = "qcom,sm8450-config-noc";
> > + reg = <0 0x01500000 0 0x1c000>;
> > + #interconnect-cells = <1>;
> > + qcom,bcm-voters = <&apps_bcm_voter>;
> > + };
> > +
> > + mc_virt: interconnect@1580000 {
> > + compatible = "qcom,sm8450-mc-virt";
> > + reg = <0 0x01580000 0 0x1000>;
> > + #interconnect-cells = <1>;
> > + qcom,bcm-voters = <&apps_bcm_voter>;
> > + };
> > +
> > + system_noc: interconnect@1680000 {
> > + reg = <0 0x01680000 0 0x1e200>;
> > + compatible = "qcom,sm8450-system-noc";
>
> Compatible first, please

will fix here and everywhere...

--
~Vinod