From: Lee Jones <lee.jones@linaro.org>
To: Orlando Chamberlain <redecorating@protonmail.com>
Cc: andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] mfd: intel-lpss-pci: fix clock speed for 38a8 UART
Date: Mon, 29 Nov 2021 12:11:13 +0000 [thread overview]
Message-ID: <YaTDYUORb6Zi52wt@google.com> (raw)
In-Reply-To: <20211124091846.11114-1-redecorating@protonmail.com>
On Wed, 24 Nov 2021, Orlando Chamberlain wrote:
> This device is found in the MacBookPro16,2, and as the MacBookPro16,1 is
> from the same generation of MacBooks and has a UART with bxt_uart_info,
> it was incorrectly assumed that the MacBookPro16,2's UART would have the
> same info.
>
> This led to the wrong clock speed being used, and the Bluetooth
> controller exposed by the UART receiving and sending random data, which
> was incorrectly assumed to be an issue with the Bluetooth stuff, not an
> error with the UART side of things.
>
> Changing the info to spt_uart_info changes the clock speed and makes it
> send and receive data correctly.
>
> Fixes: ddb1ada416fd ("mfd: intel-lpss: Add support for MacBookPro16,2 ICL-N UART")
> Signed-off-by: Orlando Chamberlain <redecorating@protonmail.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v1 -> v2: Remove blank line in tag block, add Reviewed-by.
> drivers/mfd/intel-lpss-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-11-29 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 9:19 [PATCHv2] mfd: intel-lpss-pci: fix clock speed for 38a8 UART Orlando Chamberlain
2021-11-29 12:11 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaTDYUORb6Zi52wt@google.com \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=redecorating@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox