public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Len Brown <len.brown@intel.com>,
	Thomas Richter <tmricht@linux.ibm.com>,
	Ian Rogers <irogers@google.com>
Subject: Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes
Date: Mon, 29 Nov 2021 15:03:18 +0100	[thread overview]
Message-ID: <YaTdpsVCDQMlscON@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20211129130309.3256168-1-hca@linux.ibm.com>

On Mon, Nov 29, 2021 at 02:03:06PM +0100, Heiko Carstens wrote:
> v2:
> As requested by Greg KH: avoid negative logic and use uppercase defines.
> 
> v1:
> Create die and cluster cpu topology sysfs attributes only if an
> architecture makes uses of it, instead of creating them always for all
> architectures with bogus default values.
> Also change the book and drawer cpu topology macros so they match all
> all other topology macros.
> 
> v1: https://lore.kernel.org/lkml/20211128212221.1069726-1-hca@linux.ibm.com/
> 
> Heiko Carstens (3):
>   topology/sysfs: export die attributes only if an architectures has support
>   topology/sysfs: export cluster attributes only if an architectures has support
>   topology/sysfs: rework book and drawer topology ifdefery
> 
>  Documentation/admin-guide/cputopology.rst | 33 +++++++++++------------
>  drivers/base/topology.c                   | 28 ++++++++++++++-----
>  include/linux/topology.h                  | 25 +++++++++++++++++
>  3 files changed, 62 insertions(+), 24 deletions(-)

Seems entirely reasonable to me,

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

  parent reply	other threads:[~2021-11-29 15:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 13:03 [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes Heiko Carstens
2021-11-29 13:03 ` [PATCH v2 1/3] topology/sysfs: export die attributes only if an architectures has support Heiko Carstens
2021-11-29 13:03 ` [PATCH v2 2/3] topology/sysfs: export cluster " Heiko Carstens
2021-11-29 13:03 ` [PATCH v2 3/3] topology/sysfs: rework book and drawer topology ifdefery Heiko Carstens
2021-11-29 14:03 ` Peter Zijlstra [this message]
2021-12-02 14:22   ` [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes Heiko Carstens
2021-12-02 14:26     ` Greg Kroah-Hartman
2021-12-04  9:07       ` Song Bao Hua (Barry Song)
2021-12-04  9:48         ` Brice Goglin
2021-12-04 11:45           ` Song Bao Hua (Barry Song)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaTdpsVCDQMlscON@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hca@linux.ibm.com \
    --cc=irogers@google.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox