Re: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs

Greg Kroah-Hartman
2021-11-30T08:47:01Z

On Mon, Nov 29, 2021 at 11:31:16PM -0800, Eric Biggers wrote:
> On Tue, Nov 30, 2021 at 08:13:37AM +0100, Greg Kroah-Hartman wrote:
> > > Documentation/block/queue-sysfs.rst | 30 +++++
> >
> > Same objection as before. Please add these to Documentation/ABI/
>
> As I said before, this is where all the blk-sysfs stuff is documented currently.
> If you consider this a hard requirement, then I'll get started on a patch that
> moves all of queue-sysfs.rst into Documentation/ABI/, as it's silly to change it
> for just this one and not the 23 other blk-sysfs attributes with exactly the
> same issue.

If I don't complain about it, nothing will ever change :)

> > otherwise when running 'scripts/get_abi undefined' will show these new
> > sysfs files you are adding as having no documentation :(
>
> Perhaps this should be part of checkpatch?

It's hard as that requires the code that the patch is checking to be
running on the system you run checkpatch on.

thanks,

greg k-h