From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E93C433EF for ; Tue, 30 Nov 2021 21:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344505AbhK3VyF (ORCPT ); Tue, 30 Nov 2021 16:54:05 -0500 Received: from mail.netfilter.org ([217.70.188.207]:51930 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344608AbhK3VxO (ORCPT ); Tue, 30 Nov 2021 16:53:14 -0500 Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 46ABF607E0; Tue, 30 Nov 2021 22:47:30 +0100 (CET) Date: Tue, 30 Nov 2021 22:49:42 +0100 From: Pablo Neira Ayuso To: Kees Cook Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: Use memset_startat() to zero struct nf_conn Message-ID: References: <20211118203113.1286928-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211118203113.1286928-1-keescook@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 18, 2021 at 12:31:13PM -0800, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Use memset_startat() to avoid confusing memset() about writing beyond > the target struct member. Applied to nf-next, thanks