From: Greg KH <gregkh@linuxfoundation.org>
To: davidcomponentone@gmail.com
Cc: TheSven73@gmail.com, dan.carpenter@oracle.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Yang Guang <yang.guang5@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH v3] staging: fieldbus: replace snprintf with sysfs_emit
Date: Fri, 3 Dec 2021 08:18:55 +0100 [thread overview]
Message-ID: <YanE3wbiQ3iiEe7s@kroah.com> (raw)
In-Reply-To: <36a8d3be94d3575656d08204228eaa921db64c03.1638493815.git.yang.guang5@zte.com.cn>
On Fri, Dec 03, 2021 at 09:17:32AM +0800, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
Does not match the address you send this email from as reported many
times to you.
>
> coccinelle report:
> ./drivers/staging/fieldbus/dev_core.c:73:8-16:
> WARNING: use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Again, I have commented on the use of this many times already. I will
not take this change until you at least discuss it with us.
sorry,
greg k-h
prev parent reply other threads:[~2021-12-03 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 1:17 [PATCH v3] staging: fieldbus: replace snprintf with sysfs_emit davidcomponentone
2021-12-03 7:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YanE3wbiQ3iiEe7s@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=TheSven73@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davidcomponentone@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=yang.guang5@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox