From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Yihao Han <hanyihao@vivo.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] leds: tca6507: Get rid of duplicate of_node assignment
Date: Fri, 3 Dec 2021 14:18:42 +0200 [thread overview]
Message-ID: <YaoLImUJb0K/IVOL@smile.fi.intel.com> (raw)
In-Reply-To: <20211203073121.GA27457@amd>
On Fri, Dec 03, 2021 at 08:31:21AM +0100, Pavel Machek wrote:
> Hi!
>
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove assignment here.
> >
> > For the details one may look into the of_gpio_dev_init()
> > implementation.
>
> So... where do you see of_gpio_dev_init called in this particular
> case?
Inside GPIO library as stated in the commit message.
--> tca6507_probe_gpios()
--> gpiochip_add_data()
--> gpiochip_add_data_with_key()
--> of_gpio_dev_init()
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-03 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 21:06 [PATCH v1 1/1] leds: tca6507: Get rid of duplicate of_node assignment Andy Shevchenko
2021-12-03 7:31 ` Pavel Machek
2021-12-03 12:18 ` Andy Shevchenko [this message]
2021-12-10 13:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaoLImUJb0K/IVOL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hanyihao@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox