From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/2] ASoC: ti: davinci-mcasp: Get rid of duplicate of_node assignment
Date: Fri, 3 Dec 2021 18:25:47 +0200 [thread overview]
Message-ID: <YapFC9ksQmGy6llL@smile.fi.intel.com> (raw)
In-Reply-To: <1a2831d2-49bb-f1fc-14e8-d6a0d53664cf@gmail.com>
On Fri, Dec 03, 2021 at 04:45:31PM +0200, Péter Ujfalusi wrote:
> On 02/12/2021 22:56, Andy Shevchenko wrote:
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove assignment here.
>
> Thanks, looks good,
> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Thanks!
> > For the details one may look into the of_gpio_dev_init() implementation.
>
> Which works after commit 1df62542e0161.
Actually even before that.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-03 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 20:56 [PATCH v1 1/2] ASoC: ti: davinci-mcasp: Get rid of duplicate of_node assignment Andy Shevchenko
2021-12-02 20:56 ` [PATCH v1 2/2] ASoC: ti: davinci-mcasp: Remove unnecessary conditional Andy Shevchenko
2021-12-03 14:46 ` Péter Ujfalusi
2021-12-03 14:45 ` [PATCH v1 1/2] ASoC: ti: davinci-mcasp: Get rid of duplicate of_node assignment Péter Ujfalusi
2021-12-03 16:25 ` Andy Shevchenko [this message]
2021-12-06 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YapFC9ksQmGy6llL@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox