Re: Building perf with BUILD_BPF_SKEL=1 by default

Song Liu
2021-12-07T01:07:42Z

> On Dec 6, 2021, at 4:49 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Em Mon, Dec 06, 2021 at 10:34:31PM +0000, Song Liu escreveu:
>>> From e033fd36657288ece383ba528aaff7b56eebfee2 Mon Sep 17 00:00:00 2001
>> From: Song Liu <songliubraving@fb.com>
>> Date: Fri, 3 Dec 2021 15:14:41 -0800
>> Subject: [PATCH] perf/bpf_skel: do not use typedef to avoid error on old clang
>>
>> When building bpf_skel with clang-10, typedef causes confusions like:
>>
>> libbpf: map 'prev_readings': unexpected def kind var.
>>
>> Fix this by removing the typedef.
>>
>> Fixes: 7fac83aaf2ee ("perf stat: Introduce 'bperf' to share hardware PMCs with BPF")
>
> Please get a larger sha abbrev:
>
> ⬢[acme@toolbox perf]$ grep core -A1 ~/.gitconfig
> [core]
> abbrev = 16
> ⬢[acme@toolbox perf]$

Hmm.. I think the rule is to have 12 letters sha in the Fixes tag. Did we
change something recently?

Thanks,
Song