* [PATCH] gpio: sim: fix uninitialized ret variable
@ 2021-12-18 15:27 trix
2021-12-18 21:59 ` Nathan Chancellor
2021-12-19 13:48 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: trix @ 2021-12-18 15:27 UTC (permalink / raw)
To: linus.walleij, brgl, nathan, ndesaulniers
Cc: linux-gpio, linux-kernel, llvm, Tom Rix
From: Tom Rix <trix@redhat.com>
Building with clang returns this error:
gpio-sim.c:889:7: error: variable 'ret' is uninitialized
when used here
ret should be the status of the call to
gpio_sim_make_bank_swnode stored in bank->swnode.
Fixes: 83960fcf4818 ("gpio: sim: new testing module")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpio/gpio-sim.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index ef6145f51c8ae..bef00dcc4dc8f 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -886,7 +886,8 @@ static int gpio_sim_device_activate_unlocked(struct gpio_sim_device *dev)
list_for_each_entry(bank, &dev->bank_list, siblings) {
bank->swnode = gpio_sim_make_bank_swnode(bank, swnode);
- if (ret) {
+ if (IS_ERR(bank->swnode)) {
+ ret = PTR_ERR(bank->swnode);
gpio_sim_remove_swnode_recursive(swnode);
return ret;
}
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: sim: fix uninitialized ret variable
2021-12-18 15:27 [PATCH] gpio: sim: fix uninitialized ret variable trix
@ 2021-12-18 21:59 ` Nathan Chancellor
2021-12-19 13:48 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-12-18 21:59 UTC (permalink / raw)
To: trix; +Cc: linus.walleij, brgl, ndesaulniers, linux-gpio, linux-kernel, llvm
On Sat, Dec 18, 2021 at 07:27:12AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Building with clang returns this error:
>
> gpio-sim.c:889:7: error: variable 'ret' is uninitialized
> when used here
>
> ret should be the status of the call to
> gpio_sim_make_bank_swnode stored in bank->swnode.
>
> Fixes: 83960fcf4818 ("gpio: sim: new testing module")
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/gpio/gpio-sim.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index ef6145f51c8ae..bef00dcc4dc8f 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -886,7 +886,8 @@ static int gpio_sim_device_activate_unlocked(struct gpio_sim_device *dev)
>
> list_for_each_entry(bank, &dev->bank_list, siblings) {
> bank->swnode = gpio_sim_make_bank_swnode(bank, swnode);
> - if (ret) {
> + if (IS_ERR(bank->swnode)) {
> + ret = PTR_ERR(bank->swnode);
> gpio_sim_remove_swnode_recursive(swnode);
> return ret;
> }
> --
> 2.26.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: sim: fix uninitialized ret variable
2021-12-18 15:27 [PATCH] gpio: sim: fix uninitialized ret variable trix
2021-12-18 21:59 ` Nathan Chancellor
@ 2021-12-19 13:48 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2021-12-19 13:48 UTC (permalink / raw)
To: trix
Cc: Linus Walleij, nathan, ndesaulniers, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, llvm
On Sat, Dec 18, 2021 at 4:27 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> Building with clang returns this error:
>
> gpio-sim.c:889:7: error: variable 'ret' is uninitialized
> when used here
>
> ret should be the status of the call to
> gpio_sim_make_bank_swnode stored in bank->swnode.
>
> Fixes: 83960fcf4818 ("gpio: sim: new testing module")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpio/gpio-sim.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index ef6145f51c8ae..bef00dcc4dc8f 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -886,7 +886,8 @@ static int gpio_sim_device_activate_unlocked(struct gpio_sim_device *dev)
>
> list_for_each_entry(bank, &dev->bank_list, siblings) {
> bank->swnode = gpio_sim_make_bank_swnode(bank, swnode);
> - if (ret) {
> + if (IS_ERR(bank->swnode)) {
> + ret = PTR_ERR(bank->swnode);
> gpio_sim_remove_swnode_recursive(swnode);
> return ret;
> }
> --
> 2.26.3
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-19 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-18 15:27 [PATCH] gpio: sim: fix uninitialized ret variable trix
2021-12-18 21:59 ` Nathan Chancellor
2021-12-19 13:48 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox