* [PATCH v2] firmware: Update Kconfig help text for Google firmware
@ 2018-06-18 22:55 Ben Hutchings
2018-06-18 23:13 ` Julius Werner
2021-12-19 13:08 ` Salvatore Bonaccorso
0 siblings, 2 replies; 4+ messages in thread
From: Ben Hutchings @ 2018-06-18 22:55 UTC (permalink / raw)
To: Julius Werner, Thierry Escande; +Cc: linux-kernel, Paul Menzel
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
The help text for GOOGLE_FIRMWARE states that it should only be
enabled when building a kernel for Google's own servers. However,
many of the drivers dependent on it are also useful on Chromebooks or
on any platform using coreboot.
Update the help text to reflect this double duty.
Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
v2: Mention coreboot, and don't touch GSMI help text
drivers/firmware/google/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
index f16b381a569c..ca049ecf5cfd 100644
--- a/drivers/firmware/google/Kconfig
+++ b/drivers/firmware/google/Kconfig
@@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
bool "Google Firmware Drivers"
default n
help
- These firmware drivers are used by Google's servers. They are
- only useful if you are working directly on one of their
- proprietary servers. If in doubt, say "N".
+ These firmware drivers are used by Google servers,
+ Chromebooks and other devices using coreboot firmware.
+ If in doubt, say "N".
if GOOGLE_FIRMWARE
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware
2018-06-18 22:55 [PATCH v2] firmware: Update Kconfig help text for Google firmware Ben Hutchings
@ 2018-06-18 23:13 ` Julius Werner
2021-12-19 13:08 ` Salvatore Bonaccorso
1 sibling, 0 replies; 4+ messages in thread
From: Julius Werner @ 2018-06-18 23:13 UTC (permalink / raw)
To: ben; +Cc: Julius Werner, Thierry Escande, LKML, pm.debian
LGTM
Reviewed-by: Julius Werner <jwerner@chromium.org>
On Mon, Jun 18, 2018 at 3:55 PM Ben Hutchings <ben@decadent.org.uk> wrote:
>
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers. However,
> many of the drivers dependent on it are also useful on Chromebooks or
> on any platform using coreboot.
>
> Update the help text to reflect this double duty.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> v2: Mention coreboot, and don't touch GSMI help text
>
> drivers/firmware/google/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..ca049ecf5cfd 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
> bool "Google Firmware Drivers"
> default n
> help
> - These firmware drivers are used by Google's servers. They are
> - only useful if you are working directly on one of their
> - proprietary servers. If in doubt, say "N".
> + These firmware drivers are used by Google servers,
> + Chromebooks and other devices using coreboot firmware.
> + If in doubt, say "N".
>
> if GOOGLE_FIRMWARE
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware
2018-06-18 22:55 [PATCH v2] firmware: Update Kconfig help text for Google firmware Ben Hutchings
2018-06-18 23:13 ` Julius Werner
@ 2021-12-19 13:08 ` Salvatore Bonaccorso
2021-12-21 9:12 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Salvatore Bonaccorso @ 2021-12-19 13:08 UTC (permalink / raw)
To: Ben Hutchings
Cc: Julius Werner, Thierry Escande, linux-kernel, Paul Menzel,
Greg Kroah-Hartman, Mike Waychison
Hi,
On Mon, Jun 18, 2018 at 11:55:40PM +0100, Ben Hutchings wrote:
> The help text for GOOGLE_FIRMWARE states that it should only be
> enabled when building a kernel for Google's own servers. However,
> many of the drivers dependent on it are also useful on Chromebooks or
> on any platform using coreboot.
>
> Update the help text to reflect this double duty.
>
> Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> v2: Mention coreboot, and don't touch GSMI help text
>
> drivers/firmware/google/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index f16b381a569c..ca049ecf5cfd 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
> bool "Google Firmware Drivers"
> default n
> help
> - These firmware drivers are used by Google's servers. They are
> - only useful if you are working directly on one of their
> - proprietary servers. If in doubt, say "N".
> + These firmware drivers are used by Google servers,
> + Chromebooks and other devices using coreboot firmware.
> + If in doubt, say "N".
>
> if GOOGLE_FIRMWARE
Prompted by a question downstream in Debian it looks that this patch
never go applied.
Is there anything missing for having it applied?
Do you want a fresh resent of it?
Regards,
Salvatore
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] firmware: Update Kconfig help text for Google firmware
2021-12-19 13:08 ` Salvatore Bonaccorso
@ 2021-12-21 9:12 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-12-21 9:12 UTC (permalink / raw)
To: Salvatore Bonaccorso
Cc: Ben Hutchings, Julius Werner, Thierry Escande, linux-kernel,
Paul Menzel, Mike Waychison
On Sun, Dec 19, 2021 at 02:08:51PM +0100, Salvatore Bonaccorso wrote:
> Hi,
>
> On Mon, Jun 18, 2018 at 11:55:40PM +0100, Ben Hutchings wrote:
> > The help text for GOOGLE_FIRMWARE states that it should only be
> > enabled when building a kernel for Google's own servers. However,
> > many of the drivers dependent on it are also useful on Chromebooks or
> > on any platform using coreboot.
> >
> > Update the help text to reflect this double duty.
> >
> > Fixes: d384d6f43d1e ("firmware: google memconsole: Add coreboot support")
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > v2: Mention coreboot, and don't touch GSMI help text
> >
> > drivers/firmware/google/Kconfig | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> > index f16b381a569c..ca049ecf5cfd 100644
> > --- a/drivers/firmware/google/Kconfig
> > +++ b/drivers/firmware/google/Kconfig
> > @@ -2,9 +2,9 @@ menuconfig GOOGLE_FIRMWARE
> > bool "Google Firmware Drivers"
> > default n
> > help
> > - These firmware drivers are used by Google's servers. They are
> > - only useful if you are working directly on one of their
> > - proprietary servers. If in doubt, say "N".
> > + These firmware drivers are used by Google servers,
> > + Chromebooks and other devices using coreboot firmware.
> > + If in doubt, say "N".
> >
> > if GOOGLE_FIRMWARE
>
> Prompted by a question downstream in Debian it looks that this patch
> never go applied.
>
> Is there anything missing for having it applied?
>
> Do you want a fresh resent of it?
I've picked it up now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-21 9:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-18 22:55 [PATCH v2] firmware: Update Kconfig help text for Google firmware Ben Hutchings
2018-06-18 23:13 ` Julius Werner
2021-12-19 13:08 ` Salvatore Bonaccorso
2021-12-21 9:12 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox