Re: [PATCH] perf dlfilter: Drop unused variable

Arnaldo Carvalho de Melo
2021-12-09T19:20:28Z

Em Wed, Dec 08, 2021 at 12:11:59PM +0100, Salvatore Bonaccorso escreveu:
> Hi German,
>
> On Wed, Dec 08, 2021 at 10:44:01AM +0000, German Gomez wrote:
> >
> > On 23/11/2021 21:18, Salvatore Bonaccorso wrote:
> > > Compiling tools/perf/dlfilters/dlfilter-test-api-v0.c result in:
> > >
> > > checking for stdlib.h... dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:
> > > dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
> > > 311 | struct filter_data *d = data;
> > > |
> >
> > Did you get this warning when issuing "make"? From my side, it generated
> > this gcc command so I didn't get it (make DEBUG=1):
> >
> >   gcc -c -Iinclude  -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
> >
> > Reviewed-by: German Gomez <german.gomez@arm.com>
>
> Only when passing -Wall (this is the case when building the kernel packages in
> Debian with additional flags, so this is why this was spotted):
>
> gcc -Wall -c -Iinclude  -o dlfilters/dlfilter-test-api-v0.o -fpic dlfilters/dlfilter-test-api-v0.c
> dlfilters/dlfilter-test-api-v0.c: In function ‘filter_event’:
> dlfilters/dlfilter-test-api-v0.c:311:29: warning: unused variable ‘d’ [-Wunused-variable]
> 311 | struct filter_data *d = data;
> |
>

So I'm applying this, its an obvious cleanup, but please CC the author
next time, I'm doing it in this reply, Adrian, ok?

- Arnaldo