From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] i2c: core: Do not dereference fwnode in struct device
Date: Thu, 9 Dec 2021 12:08:39 +0200 [thread overview]
Message-ID: <YbHVpwl5uGpV+Lei@smile.fi.intel.com> (raw)
In-Reply-To: <YbHCAURU5bR3XFL2@ninjato>
On Thu, Dec 09, 2021 at 09:44:49AM +0100, Wolfram Sang wrote:
>
> > client->dev.parent = &client->adapter->dev;
> > client->dev.bus = &i2c_bus_type;
> > client->dev.type = &i2c_client_type;
> > - client->dev.of_node = of_node_get(info->of_node);
> > - client->dev.fwnode = info->fwnode;
> >
> > device_enable_async_suspend(&client->dev);
> > i2c_dev_set_name(adap, client, info);
> >
> > + device_set_node(&client->dev, info->fwnode);
> > + client->dev.of_node = of_node_get(info->of_node);
> > +
>
> I am basically OK with this change. I'd just move the code block a
> little to have the same behaviour as before. Something like this
> (hand-edited preview version):
And this is exactly what have been done.
> > client->dev.bus = &i2c_bus_type;
> > client->dev.type = &i2c_client_type;
> > client->dev.of_node = of_node_get(info->of_node);
> > - client->dev.fwnode = info->fwnode;
> >
> > + device_set_node(&client->dev, info->fwnode);
> > device_enable_async_suspend(&client->dev);
> > i2c_dev_set_name(adap, client, info);
>
> Are you okay with that?
It will be broken in this case. There is subtle detail about device_set_node(),
it sets both fwnode and of_node at once. More thinking about this, I admit that
the best strategy now is to drop this change for now.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-09 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 16:24 [PATCH v1 1/1] i2c: core: Do not dereference fwnode in struct device Andy Shevchenko
2021-12-09 8:44 ` Wolfram Sang
2021-12-09 10:08 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbHVpwl5uGpV+Lei@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox