From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
Date: Fri, 10 Dec 2021 12:44:15 +0200 [thread overview]
Message-ID: <YbMvfzKsc4CcQzSa@smile.fi.intel.com> (raw)
In-Reply-To: <15cf03b2-8d45-93b1-f0a0-d79c93cee0da@omp.ru>
On Thu, Dec 09, 2021 at 11:29:07PM +0300, Sergey Shtylyov wrote:
> On 12/9/21 10:22 PM, Andy Shevchenko wrote:
...
> >>>>> While at it, drop redundant check for 0 as platform_get_irq() spills
> >>>>> out a big WARN() in such case.
> >>>>
> >>>> And? IRQ0 is still returned! :-(
> >>>
> >>> It should not be returned in the first place.
> >>
> >> But it still is, despite the WARN(), right?
> >
> > So, you admit that there is a code which does that?
>
> I admit *what*?! That platfrom_get_irq() and its ilk return IRQ0 while they
> shouldn't? =)
That there is a code beneath platform_get_irq() that returns 0, yes.
> > That code should be fixed first. Have you sent a patch?
>
> Which code?! You got me totally muddled. =)
Above mentioned.
...
> >>>>> - if (!irq)
> >>>>> - return -EINVAL;
> >>>>
> >>>> This is prermature -- let's wait till my patch that stops returning IRQ0 from
> >>>> platform_get_irq() and friends gets merged....
> >>>
> >>> What patch?
> >>
> >> https://marc.info/?l=linux-kernel&m=163623041902285
> >>
> >>> Does it fix platform_get_irq_optional()?
> >>
> >> Of course! :-)
> >
> > Can you share link to lore.kernel.org, please?
> > It will make much easier to try and comment.
>
> I don't know how to uise it yet, and I'm a little busy with other IRQ0 issues ATM,
> so I'm afraid you're on your own here...
lore.kernel.org is the official mailing list archive for Linux kernel work
AFAIU. Other sites may do whatever they want with that information, so -->
they are unreliable. If you wish to follow the better process, use
lore.kernel.org. Understanding how it works takes no more than 5 minutes
by engineer with your kind of experience with Linux kernel development.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-10 10:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:59 [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Andy Shevchenko
2021-12-09 14:59 ` [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt Andy Shevchenko
2021-12-10 19:34 ` Andy Shevchenko
2021-12-11 0:04 ` Damien Le Moal
2021-12-17 0:58 ` Damien Le Moal
2021-12-17 11:57 ` Andy Shevchenko
2021-12-09 15:21 ` [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Hans de Goede
2021-12-09 17:24 ` Sergey Shtylyov
2021-12-09 17:42 ` Andy Shevchenko
2021-12-09 18:22 ` Sergey Shtylyov
2021-12-09 19:22 ` Andy Shevchenko
2021-12-09 19:27 ` Andy Shevchenko
2021-12-09 20:31 ` Sergey Shtylyov
2021-12-09 20:29 ` Sergey Shtylyov
2021-12-10 10:44 ` Andy Shevchenko [this message]
2021-12-10 11:14 ` Sergey Shtylyov
2021-12-10 11:28 ` Andy Shevchenko
2021-12-10 17:39 ` Sergey Shtylyov
2021-12-10 17:51 ` Andy Shevchenko
2021-12-09 22:49 ` Damien Le Moal
2021-12-09 22:57 ` Damien Le Moal
2021-12-10 8:47 ` Andy Shevchenko
2021-12-10 16:38 ` Sergey Shtylyov
2021-12-10 17:57 ` Andy Shevchenko
2021-12-10 8:59 ` Sergey Shtylyov
2021-12-10 10:46 ` Andy Shevchenko
2021-12-10 11:19 ` Sergey Shtylyov
2021-12-10 11:36 ` Andy Shevchenko
2021-12-10 17:15 ` Sergei Shtylyov
2021-12-10 17:59 ` Andy Shevchenko
2021-12-10 19:01 ` Sergey Shtylyov
2021-12-10 19:25 ` Andy Shevchenko
2021-12-10 19:30 ` Sergey Shtylyov
2021-12-10 19:35 ` Sergei Shtylyov
2021-12-11 10:13 ` Sergey Shtylyov
2021-12-13 11:26 ` Andy Shevchenko
2021-12-10 23:45 ` Damien Le Moal
2021-12-11 10:25 ` Sergey Shtylyov
2021-12-12 22:39 ` Damien Le Moal
2021-12-13 11:52 ` Andy Shevchenko
2021-12-13 21:36 ` Damien Le Moal
2021-12-13 22:02 ` Andy Shevchenko
2021-12-13 11:49 ` Andy Shevchenko
2021-12-13 11:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbMvfzKsc4CcQzSa@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox