From: Heiko Carstens <hca@linux.ibm.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Jerome Marchand <jmarchan@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] recordmcount.pl: look for jgnop instruction as well as bcrl on s390
Date: Fri, 10 Dec 2021 16:51:35 +0100 [thread overview]
Message-ID: <YbN3h7cyC01adiwr@osiris> (raw)
In-Reply-To: <alpine.LSU.2.21.2112101321010.5704@pobox.suse.cz>
On Fri, Dec 10, 2021 at 01:31:23PM +0100, Miroslav Benes wrote:
> > > Otherwise I would be surprised that this would make any difference.
> >
> > How come? I mean, s390 does not define HAVE_C_RECORDMCOUNT which implies
> > that recordmcount.pl is used (see scripts/Makefile.build and
> > BUILD_C_RECORDMCOUNT definition in Makefile).
>
> Ah, sorry, that was too quick.
>
> I guess you want to say that recordmcount is not used at all and GCC
> should do it. Because CONFIG_FTRACE_MCOUNT_USE_RECORDMCOUNT is not set,
> since FTRACE_MCOUNT_USE_CC should be set.
>
> What a maze.
>
> But isn't -mrecord-mcount x86_64-only option?
No, it is (at least) also supported on s390. IIRC that was added with
gcc9. Anyway, this is not too important since the fix makes sense
anyway.
next prev parent reply other threads:[~2021-12-10 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 9:38 [PATCH] recordmcount.pl: look for jgnop instruction as well as bcrl on s390 Jerome Marchand
2021-12-10 9:57 ` Miroslav Benes
2021-12-10 10:58 ` Heiko Carstens
2021-12-10 12:16 ` Miroslav Benes
2021-12-10 12:31 ` Miroslav Benes
2021-12-10 15:51 ` Heiko Carstens [this message]
2021-12-10 17:40 ` Steven Rostedt
2021-12-13 8:13 ` Jerome Marchand
2021-12-23 8:52 ` Miroslav Benes
2021-12-23 17:40 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbN3h7cyC01adiwr@osiris \
--to=hca@linux.ibm.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox