From: Rob Herring <robh@kernel.org>
To: YC Hung <yc.hung@mediatek.com>
Cc: broonie@kernel.org, tiwai@suse.com, matthias.bgg@gmail.com,
alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
daniel.baluta@nxp.com, peter.ujfalusi@intel.com,
trevor.wu@mediatek.com, allen-kh.cheng@mediatek.com
Subject: Re: [PATCH v6] dt-bindings: dsp: mediatek: Add mt8195 DSP binding support
Date: Fri, 10 Dec 2021 14:10:24 -0600 [thread overview]
Message-ID: <YbO0MKXKYN48+kzN@robh.at.kernel.org> (raw)
In-Reply-To: <20211202144818.31626-1-yc.hung@mediatek.com>
On Thu, Dec 02, 2021 at 10:48:18PM +0800, YC Hung wrote:
> From: "yc.hung" <yc.hung@mediatek.com>
>
> This describes the mt8195 DSP device tree node.
This doesn't match the change.
>
> Signed-off-by: yc.hung <yc.hung@mediatek.com>
> ---
> Changes since v5:
> Remove sub node "sound" and "mediatek,platform", "mediatek,dptx-codec",
> "mediatek,hdmi-codec" properties. Let dsp node as an individual node and
> sound card has phandle of this dsp node per discussion in
> https://github.com/thesofproject/linux/pull/3239
>
> Changes since v4:
> - remove patch 1 with clocks as it will be reviewed and merged to SOF tree.
> https://github.com/thesofproject/linux/pull/3237
> - refine DT file binding files with Rob's comments.
> ---
> .../bindings/dsp/mtk,mt8195-dsp.yaml | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> index f8bacd50b018..33db11ee2336 100644
> --- a/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mtk,mt8195-dsp.yaml
> @@ -70,22 +70,6 @@ properties:
> - description: A phandle to a reserved memory region is used for dma buffer between host and DSP.
> - description: A phandle to a reserved memory region is used for DSP system memory.
>
> - model:
> - $ref: /schemas/types.yaml#/definitions/string
> - description: User specified audio sound card name
> -
> - mediatek,platform:
> - $ref: "/schemas/types.yaml#/definitions/phandle"
> - description: The phandle of MT8195 ASoC platform.
> -
> - mediatek,dptx-codec:
> - $ref: "/schemas/types.yaml#/definitions/phandle"
> - description: The phandle of MT8195 Display Port Tx codec node.
> -
> - mediatek,hdmi-codec:
> - $ref: "/schemas/types.yaml#/definitions/phandle"
> - description: The phandle of MT8195 HDMI codec node.
> -
> required:
> - compatible
> - reg
> @@ -98,7 +82,6 @@ required:
> - power-domains
> - mbox-names
> - mboxes
> - - mediatek,platform
>
> additionalProperties: false
>
> @@ -130,6 +113,4 @@ examples:
> power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> mbox-names = "mbox0", "mbox1";
> mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> - mediatek,dptx-codec = <&dp_tx>;
> - mediatek,platform = <&afe>;
> };
> --
> 2.18.0
>
>
prev parent reply other threads:[~2021-12-10 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 14:48 [PATCH v6] dt-bindings: dsp: mediatek: Add mt8195 DSP binding support YC Hung
2021-12-10 20:10 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbO0MKXKYN48+kzN@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@intel.com \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox