Re: [PATCH v1 1/2] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved

Andy Shevchenko
2021-12-09T19:23:58Z

On Thu, Dec 09, 2021 at 09:22:32PM +0300, Sergey Shtylyov wrote:
> On 12/9/21 8:42 PM, Andy Shevchenko wrote:

...

> >>> No need to repeat this.
> >>>
> >>> While at it, drop redundant check for 0 as platform_get_irq() spills
> >>> out a big WARN() in such case.
> >>
> >> And? IRQ0 is still returned! :-(
> >
> > It should not be returned in the first place.
>
> But it still is, despite the WARN(), right?

So, you admit that there is a code which does that? That code should be fixed
first. Have you sent a patch?

...

> >>> - if (!irq)
> >>> - return -EINVAL;
> >>
> >> This is prermature -- let's wait till my patch that stops returning IRQ0 from
> >> platform_get_irq() and friends gets merged....
> >
> > What patch?
>
> https://marc.info/?l=linux-kernel&m=163623041902285
>
> > Does it fix platform_get_irq_optional()?
>
> Of course! :-)

Can you share link to lore.kernel.org, please?
It will make much easier to try and comment.

--
With Best Regards,
Andy Shevchenko