From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BFDAC433EF for ; Fri, 10 Dec 2021 19:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242155AbhLJTjS (ORCPT ); Fri, 10 Dec 2021 14:39:18 -0500 Received: from mga17.intel.com ([192.55.52.151]:28529 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233361AbhLJTjR (ORCPT ); Fri, 10 Dec 2021 14:39:17 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10194"; a="219115035" X-IronPort-AV: E=Sophos;i="5.88,196,1635231600"; d="scan'208";a="219115035" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2021 11:35:41 -0800 X-IronPort-AV: E=Sophos;i="5.88,196,1635231600"; d="scan'208";a="463782721" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2021 11:35:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mvlfG-004czL-2t; Fri, 10 Dec 2021 21:34:42 +0200 Date: Fri, 10 Dec 2021 21:34:41 +0200 From: Andy Shevchenko To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hans de Goede , Jens Axboe , Damien Le Moal Subject: Re: [PATCH v1 2/2] ata: libahci_platform: Remove bogus 32-bit DMA mask attempt Message-ID: References: <20211209145937.77719-1-andriy.shevchenko@linux.intel.com> <20211209145937.77719-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211209145937.77719-2-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 09, 2021 at 04:59:37PM +0200, Andy Shevchenko wrote: > If 64-bit mask attempt fails, the 32-bit will fail by the very same reason. > Don't even try the latter. It's a continuation of the changes that contains, > e.g. dcc02c19cc06 ("sata_sil24: use dma_set_mask_and_coherent"). I understand that some people have nothing besides bikeshedding, but this patch seems fine to everybody, am I right? Can it be applied (it's independent from patch 1 anyways)? -- With Best Regards, Andy Shevchenko