Re: [PATCH v5 1/5] mfd: da9062: make register CONFIG_I writable

Guenter Roeck
2021-12-06T17:13:35Z

On 12/6/21 8:46 AM, Adam Thomson wrote:
> On 06 December 2021 06:47, Andrej Picej wrote:
>
>> From: Stefan Christ <s.christ@phytec.de>
>>
>> Make the config register CONFIG_I writable to change the watchdog mode.
>>
>> Signed-off-by: Stefan Christ <s.christ@phytec.de>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>
> I've already provided 'Reviewed-by' tags for the other patches in this set. In
> the future you can add any received tags on to patch re-submissions where
> nothing has changed since last review.
>
> Anyway, thanks for the work on this, and for the patch set:
>
> Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
>

In this context:

I expect that tags are present in patchwork. If a submitter drops tags
in a new revision of a patch series, those will get lost. The underlying
assumption is that the submitter had a reason to drop tags, such as
substantial changes in an affected patch. I can not assume that the
submitter dropped a tag accidentally and re-apply it, unless the reason
was explicitly provided (obviously that is typically not the case since
people don't usually add "accidentally dropped Reviewed-by: tags" to
change logs).

Also, I do not look into one patch of a series and apply tags to other
patches of that series. Similar reason, only here it is worse because Wim
may pull a patch from patchwork, from an e-mail, or from my watchdog-next
branch. We can't have all of them have different tags, so I take what is
in patchwork and nothing else (and your updated Reviewed-by: tag will
not apply to other patches of the series because it isn't in patchwork
for those).

I also see that my own Reviewed-by: tag (or tags, I didn't check all
of them) was/were dropped in v5 of this series. That means I'll have to
re-review the series to see what changed, which will take time and means
that the series will end up at the bottom of my review queue.
Please keep that in mind when dropping tags.

Guenter