From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75702C433FE for ; Sun, 12 Dec 2021 16:31:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231670AbhLLQbb (ORCPT ); Sun, 12 Dec 2021 11:31:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbhLLQba (ORCPT ); Sun, 12 Dec 2021 11:31:30 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1071C061714; Sun, 12 Dec 2021 08:31:29 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id m12so20563413ljj.6; Sun, 12 Dec 2021 08:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eQdIOft1oYAqdZXW3N3vDzYovCItAhD3mQzWFf5HB24=; b=YqfScbKsBHI/NoNETMQ7U1DyexFNvL5oLjAkvyPEiJf3PsvdarLnzxjzdZpkaDaNeG lMB9pU8AG4esjWdSlKefZ3TpGzn49P9RfUSRVFmTi8Q3DXaDO418ikSiLH6MoanIzQXb Kg5iDQuubTDuzlZqYCI5JvHLUf3k2Fdr98Rasfk5LwQCmMXVYTWrwvioDJ7bSrCMVYUh 1DndqasTcZymXSD63dFqKOFzFtNsIgEruJLgPkeaWjV9X3a+aKku9xLxMX2ogL+iH3tD BxWfcodoon6nSMUML20aQKaCvTeuBJr7uLeC9G5camZ9IcpOnAlDSFwu+F4D81ygIDVm LsGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eQdIOft1oYAqdZXW3N3vDzYovCItAhD3mQzWFf5HB24=; b=R88AGRgf/hVE87AHgMnSy+k+5NwJ7Pa0oP0Y7D2r+SPjw5k4j8eUOhE32ici+5/fhL rjLWE6b9/ms+pSmlQw+fniWvO6BNBImf1KGyTJiIQSxk/ueGtsOrU7vYx/uH9QrmGjs3 RxJAqChXnGExhak+f5B0cUMACrldYnS10CaQyEw2m0mN4wA2YXPbpa6fSj0PWs4T45zh EB2a1oSONmI87ulcBj3yOh72IMFOaMLbOyrBFAB5yU4xf6JguRkk254kv+KWykWtIWEc zkcTTYpXNZB3CH2fk2uVCReY1pd68IkEF0E2t1fVWaHFArO3uHpRZV55yEmhUFGTw+Q2 DgJA== X-Gm-Message-State: AOAM531GdfKFqkFd1yY35lyTkudok9pcO553UFSwjEGnehDezi9hTvgJ 81V/IllxfE0fZH/660rFryA= X-Google-Smtp-Source: ABdhPJxNRTqbYOnypQev6NPLw5f5F4aKudoYQj4wp9j9KozfyEV/1ORfo6k4+6He4jzgVAnFlMjKpw== X-Received: by 2002:a2e:7819:: with SMTP id t25mr24793253ljc.374.1639326688211; Sun, 12 Dec 2021 08:31:28 -0800 (PST) Received: from trashcan (public-nat-10.vpngate.v4.open.ad.jp. [219.100.37.242]) by smtp.gmail.com with ESMTPSA id b14sm1090934lfs.174.2021.12.12.08.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Dec 2021 08:31:27 -0800 (PST) Date: Sun, 12 Dec 2021 15:57:09 +0000 From: Vladimir Lypak To: Dmitry Baryshkov Cc: Bjorn Andersson , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , AngeloGioacchino Del Regno , Konrad Dybcio , "Kristian H. Kristensen" , Marijn Suijten , Akhil P Oommen , Jonathan Marek , Iskren Chernev , Sai Prakash Ranjan , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/msm/a5xx: Add support for Adreno 506 GPU Message-ID: References: <20211022114349.102552-1-vladimir.lypak@gmail.com> <8ee2b4d4-44f3-6d03-b674-613b5b04a754@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ee2b4d4-44f3-6d03-b674-613b5b04a754@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 03, 2021 at 09:51:10PM +0300, Dmitry Baryshkov wrote: > On 22/10/2021 20:33, Bjorn Andersson wrote: > > On Fri 22 Oct 04:43 PDT 2021, Vladimir Lypak wrote: > > > > > This GPU is found on SoCs such as MSM8953(650MHz), SDM450(600MHz), > > > SDM632(725MHz). > > > > > > Signed-off-by: Vladimir Lypak > > > --- > > > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 34 ++++++++++++++-------- > > > drivers/gpu/drm/msm/adreno/adreno_device.c | 18 ++++++++++++ > > > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ++++ > > > 3 files changed, 45 insertions(+), 12 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > > index 5e2750eb3810..249a0d8bc673 100644 > > > --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > > +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c > > > @@ -441,7 +441,7 @@ void a5xx_set_hwcg(struct msm_gpu *gpu, bool state) > > > const struct adreno_five_hwcg_regs *regs; > > > unsigned int i, sz; > > > - if (adreno_is_a508(adreno_gpu)) { > > > + if (adreno_is_a506(adreno_gpu) || adreno_is_a508(adreno_gpu)) { > > > regs = a50x_hwcg; > > > sz = ARRAY_SIZE(a50x_hwcg); > > > } else if (adreno_is_a509(adreno_gpu) || adreno_is_a512(adreno_gpu)) { > > > @@ -485,7 +485,7 @@ static int a5xx_me_init(struct msm_gpu *gpu) > > > OUT_RING(ring, 0x00000000); > > > /* Specify workarounds for various microcode issues */ > > > - if (adreno_is_a530(adreno_gpu)) { > > > + if (adreno_is_a506(adreno_gpu) || adreno_is_a530(adreno_gpu)) { > > > /* Workaround for token end syncs > > > * Force a WFI after every direct-render 3D mode draw and every > > > * 2D mode 3 draw > > > @@ -620,8 +620,17 @@ static int a5xx_ucode_init(struct msm_gpu *gpu) > > > static int a5xx_zap_shader_resume(struct msm_gpu *gpu) > > > { > > > + struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu); > > > int ret; > > > + /* > > > + * Adreno 506,508,512 have CPZ Retention feature and > > > + * don't need to resume zap shader > > > + */ > > > + if (adreno_is_a506(adreno_gpu) || adreno_is_a508(adreno_gpu) || > > > + adreno_is_a512(adreno_gpu)) > > > + return 0; > > > > Afaict all other changes in the patch adds a506 support, but this hunk > > changes a508 and a512 behavior. > > > > I'm not saying that the change is wrong, but this hunk deserves to be in > > it's own patch - so that if there's any impact on those other versions > > it can be tracked down to that specific patch. > > Vladimir, any plans to submit v2? This comment requests splitting the patch > in two. > > > -- > With best wishes > Dmitry Hello, Dmitry! Sorry for delay. Yes, i'm going to submit v2 soon. Thanks Vladimir