From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
lianzhi chang <changlianzhi@uniontech.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, 282827961@qq.com,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v20] tty: Fix the keyboard led light display problem
Date: Mon, 13 Dec 2021 11:41:09 -0800 [thread overview]
Message-ID: <Ybeh1VGMvL7DkG2I@google.com> (raw)
In-Reply-To: <97eb3c3f68042443aa71c10766f3bef364e8f90b.camel@perches.com>
On Mon, Dec 13, 2021 at 04:41:24AM -0800, Joe Perches wrote:
> On Mon, 2021-12-13 at 14:15 +0200, Andy Shevchenko wrote:
> > On Mon, Dec 13, 2021 at 02:12:44PM +0800, lianzhi chang wrote:
>
> > > + struct kbd_struct *kb = &kbd_table[console];
> > > + int ret = 0;
> > > + unsigned long flags;
> >
> > Slightly better to read:
> >
> > struct kbd_struct *kb = &kbd_table[console];
> > unsigned long flags;
> > int ret = 0;
>
> I don't think so. Why do you?
I wonder why we comment on cosmetics of a patch (and have the submitter
rush to fix that) without considering if the proposed solution makes
sense in the first place?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-12-13 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 6:12 [PATCH v20] tty: Fix the keyboard led light display problem lianzhi chang
2021-12-13 12:15 ` Andy Shevchenko
2021-12-13 12:41 ` Joe Perches
2021-12-13 19:41 ` Dmitry Torokhov [this message]
2021-12-13 20:06 ` Andy Shevchenko
2021-12-13 21:38 ` Dmitry Torokhov
2021-12-13 13:20 ` Dan Carpenter
2021-12-13 13:36 ` Greg KH
2021-12-13 19:39 ` Dmitry Torokhov
2021-12-14 2:06 ` lianzhi chang
2021-12-14 5:40 ` dmitry.torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybeh1VGMvL7DkG2I@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=282827961@qq.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changlianzhi@uniontech.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox