* [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice
@ 2021-12-14 8:09 Bartosz Golaszewski
2021-12-14 12:04 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-12-14 8:09 UTC (permalink / raw)
To: Kent Gibson, Linus Walleij, Andy Shevchenko, Shuah Khan,
Geert Uytterhoeven, Viresh Kumar
Cc: linux-gpio, linux-kernel, linux-kselftest, Bartosz Golaszewski
Use '-o' within [] in order to avoid spawning two processes for test.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
tools/testing/selftests/gpio/gpio-sim.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh
index c913d5aec768..341e3de00896 100755
--- a/tools/testing/selftests/gpio/gpio-sim.sh
+++ b/tools/testing/selftests/gpio/gpio-sim.sh
@@ -23,7 +23,7 @@ remove_chip() {
for FILE in $CONFIGFS_DIR/$CHIP/*; do
BANK=`basename $FILE`
- if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then
+ if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then
continue
fi
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice
2021-12-14 8:09 [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice Bartosz Golaszewski
@ 2021-12-14 12:04 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-12-14 12:04 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Kent Gibson, Linus Walleij, Shuah Khan, Geert Uytterhoeven,
Viresh Kumar, linux-gpio, linux-kernel, linux-kselftest
On Tue, Dec 14, 2021 at 09:09:19AM +0100, Bartosz Golaszewski wrote:
> Use '-o' within [] in order to avoid spawning two processes for test.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
> tools/testing/selftests/gpio/gpio-sim.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh
> index c913d5aec768..341e3de00896 100755
> --- a/tools/testing/selftests/gpio/gpio-sim.sh
> +++ b/tools/testing/selftests/gpio/gpio-sim.sh
> @@ -23,7 +23,7 @@ remove_chip() {
>
> for FILE in $CONFIGFS_DIR/$CHIP/*; do
> BANK=`basename $FILE`
> - if [ "$BANK" = "live" ] || [ "$BANK" = "dev_name" ]; then
> + if [ "$BANK" = "live" -o "$BANK" = "dev_name" ]; then
> continue
> fi
>
> --
> 2.30.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-14 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-14 8:09 [PATCH -next] selftests: gpio: gpio-sim: avoid forking test twice Bartosz Golaszewski
2021-12-14 12:04 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox