From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>
Subject: Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first parameter in orion_gpio_init()
Date: Tue, 14 Dec 2021 15:58:46 +0200 [thread overview]
Message-ID: <YbijFsYMshx7Sy4g@smile.fi.intel.com> (raw)
In-Reply-To: <YbifCSYfbKoYuzDX@shell.armlinux.org.uk>
On Tue, Dec 14, 2021 at 01:41:29PM +0000, Russell King (Oracle) wrote:
> On Tue, Dec 14, 2021 at 03:32:43PM +0200, Andy Shevchenko wrote:
> > The OF node pointer is always NULL, get rid of unused parameter in
> > orion_gpio_init(). As a side effect it will allow to switch GPIO
> > library to the fwnode API, as well as in case of resurrecting it here
> > it should be fwnode_handle anyways.
>
> Please ensure the new code follows the existing style - especially in
> terms of wrapping. Some of us still use 80 columns as a general rule.
> Thanks.
Ah, okay, I will fix that for v2.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-12-14 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 13:32 [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first parameter in orion_gpio_init() Andy Shevchenko
2021-12-14 13:41 ` Russell King (Oracle)
2021-12-14 13:58 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbijFsYMshx7Sy4g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox