From: Mike Rapoport <rppt@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Nicolas Boichat <drinkcat@chromium.org>,
Quentin Perret <qperret@google.com>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v2] of/fdt: Don't worry about non-memory region overlap for no-map
Date: Wed, 15 Dec 2021 12:01:59 +0200 [thread overview]
Message-ID: <Ybm9F5AdCSGz6IwN@kernel.org> (raw)
In-Reply-To: <Ybm6KQiS7B28QOSW@kernel.org>
On Wed, Dec 15, 2021 at 11:49:37AM +0200, Mike Rapoport wrote:
>
> On Tue, Dec 14, 2021 at 11:20:11PM -0800, Stephen Boyd wrote:
> > @@ -482,9 +482,11 @@ static int __init early_init_dt_reserve_memory_arch(phys_addr_t base,
> > if (nomap) {
> > /*
> > * If the memory is already reserved (by another region), we
> > - * should not allow it to be marked nomap.
> > + * should not allow it to be marked nomap, but don't worry
> > + * if the region isn't memory as it won't be mapped.
> > */
> > - if (memblock_is_region_reserved(base, size))
> > + if (memblock_overlaps_region(&memblock.memory, base, size) &&
> > + memblock_is_region_reserved(base, size))
One more small thing. Maybe add pr_warn() here?
> > return -EBUSY;
> >
> > return memblock_mark_nomap(base, size);
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-12-15 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 7:20 [PATCH v2] of/fdt: Don't worry about non-memory region overlap for no-map Stephen Boyd
2021-12-15 9:49 ` Mike Rapoport
2021-12-15 10:01 ` Mike Rapoport [this message]
2021-12-15 19:24 ` Stephen Boyd
2021-12-15 19:28 ` Stephen Boyd
2021-12-16 16:43 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybm9F5AdCSGz6IwN@kernel.org \
--to=rppt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qperret@google.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).