RE: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up

Joakim Zhang
2021-12-16T04:52:46Z

> -----Original Message-----
> From: Francesco Dolcini <francesco.dolcini@toradex.com>
> Sent: 2021年12月15日 19:02
> To: Andrew Lunn <andrew@lunn.ch>; Russell King (Oracle)
> <linux@armlinux.org.uk>; Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: Russell King (Oracle) <linux@armlinux.org.uk>; Francesco Dolcini
> <francesco.dolcini@toradex.com>; Philippe Schenker
> <philippe.schenker@toradex.com>; netdev@vger.kernel.org; Joakim Zhang
> <qiangqing.zhang@nxp.com>; David S . Miller <davem@davemloft.net>;
> Heiner Kallweit <hkallweit1@gmail.com>; Jakub Kicinski <kuba@kernel.org>;
> Fabio Estevam <festevam@gmail.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next 3/3] net: fec: reset phy on resume after
> power-up
>
[...]

> On Wed, Dec 15, 2021 at 10:25:14AM +0000, Joakim Zhang wrote:
> > As I mentioned before, both mac and phylib have not taken PHY reset
> > into consideration during system suspend/resume scenario. As Andrew
> > suggested, you could move this into phy driver suspend function, this
> > is a corner case. One point I don't understand, why do you reject to
> > assert reset signal during system suspended?
> See my answer to Andrew above, in short asserting the reset without
> disabling the regulator will create a regression on the power consumption.

As I can see, when system suspended, PHY is totally powered down, since you disable the
regulator. At this situation, if you assert reset signal, you mean it will increase the power
consumption? PHY is totally powered down, why assert reset signal still affect PHY?

Best Regards,
Joakim Zhang