From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Arseny Demidov <arsdemal@gmail.com>
Cc: rahul.tanwar@linux.intel.com,
Arseny Demidov <a.demidov@yadro.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo
Date: Thu, 16 Dec 2021 16:19:14 +0200 [thread overview]
Message-ID: <YbtK4mHxpdF5VtOk@smile.fi.intel.com> (raw)
In-Reply-To: <20211216083302.986-1-a.demidov@yadro.com>
On Thu, Dec 16, 2021 at 11:33:02AM +0300, Arseny Demidov wrote:
> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256,
> the correct value should be 0x100. The register ip_tmr is expressed
> in units of IP clk cycles, in accordance with the datasheet.
> Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
Should you provide Fixes tag?
...
> -#define POWER_DELAY_CYCLE_256 0x80
> +#define POWER_DELAY_CYCLE_256 0x100
> #define POWER_DELAY_CYCLE_64 0x40
I;m wondering why they are in hex? Perhaps the decimal is better for both.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-12-16 14:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 8:33 [PATCH] hwmon : (mr75203) fix macro typo Arseny Demidov
2021-12-16 14:19 ` Andy Shevchenko [this message]
2021-12-17 16:05 ` Guenter Roeck
2021-12-17 16:45 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2021-12-15 11:30 Arseny Demidov
2021-12-15 11:59 ` Guenter Roeck
2021-12-15 12:31 ` Guenter Roeck
2021-12-15 12:36 ` Arseny Demidov
2021-12-15 16:27 ` Guenter Roeck
2021-12-16 14:26 ` Andy Shevchenko
2021-12-16 14:40 ` Guenter Roeck
2021-12-16 14:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtK4mHxpdF5VtOk@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=a.demidov@yadro.com \
--cc=arsdemal@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rahul.tanwar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox