From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/build: use the proper name CONFIG_FW_LOADER
Date: Thu, 30 Dec 2021 10:29:34 +0100 [thread overview]
Message-ID: <Yc17/mHjtoqpilqm@kroah.com> (raw)
In-Reply-To: <Ycy4q2OhwTdLl+2S@zn.tnic>
On Wed, Dec 29, 2021 at 08:36:11PM +0100, Borislav Petkov wrote:
> On Wed, Dec 29, 2021 at 12:15:53PM +0100, Lukas Bulwahn wrote:
> > Commit c8dcf655ec81 ("x86/build: Tuck away built-in firmware under
> > FW_LOADER") intends to add the expression regex only when FW_LOADER is
> > built-in, not a module or disabled.
> >
> > The config is called CONFIG_FW_LOADER when it is built-in; and
> > CONFIG_FW_LOADER_MODULE when it is a module.
>
> $ git grep FW_LOADER_MODULE
> include/linux/firmware.h:37:#if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE))
>
> So either I'm not grepping right or that FW_LOADER_MODULE thing belongs
> to the past...
>
> Greg, Luis, what's up?
Looks like a pre-git thing, it is obviously not a valid config option,
so it can be removed. I'll go make a patch for it...
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-30 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 11:15 [PATCH] x86/build: use the proper name CONFIG_FW_LOADER Lukas Bulwahn
2021-12-29 14:16 ` Greg Kroah-Hartman
2021-12-29 19:36 ` Borislav Petkov
2021-12-30 9:29 ` Greg Kroah-Hartman [this message]
2021-12-29 21:29 ` [tip: x86/urgent] x86/build: Use " tip-bot2 for Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc17/mHjtoqpilqm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox