The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: ycaibb <ycaibb@gmail.com>
Cc: vapier@gmail.com, zbr@ioremap.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] connector: fix socket leak
Date: Thu, 30 Dec 2021 09:47:06 +0100	[thread overview]
Message-ID: <Yc1yCp3RI0/zT2zn@kroah.com> (raw)
In-Reply-To: <20211230082059.98012-1-ycaibb@gmail.com>

On Thu, Dec 30, 2021 at 04:20:59PM +0800, ycaibb wrote:
> In main() of ucon.c, the socket may not be closed when send_msgs is true.
> 
> Signed-off-by: ycaibb <ycaibb@gmail.com>

Please use your full name.

> ---
>  samples/connector/ucon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/samples/connector/ucon.c b/samples/connector/ucon.c
> index fa17f864200e..4f9d93a5c107 100644
> --- a/samples/connector/ucon.c
> +++ b/samples/connector/ucon.c
> @@ -180,7 +180,8 @@ int main(int argc, char *argv[])
>  
>  			ulog("%d messages have been sent to %08x.%08x.\n", i, data->id.idx, data->id.val);
>  		}
> -
> +		

Always run your patches through scripts/checkpatch.pl before sending
them out.

thanks,

greg k-h

           reply	other threads:[~2021-12-30  8:47 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20211230082059.98012-1-ycaibb@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yc1yCp3RI0/zT2zn@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gmail.com \
    --cc=ycaibb@gmail.com \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox