From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: kernel@nn7.de, mjg59@srcf.ucam.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+b88c5eae27386b252bbd@syzkaller.appspotmail.com
Subject: Re: [PATCH] input: appletouch: initialize work before device registration
Date: Thu, 30 Dec 2021 21:04:18 -0800 [thread overview]
Message-ID: <Yc6PUmjd4BDctN9h@google.com> (raw)
In-Reply-To: <20211230141151.17300-1-paskripkin@gmail.com>
On Thu, Dec 30, 2021 at 05:11:51PM +0300, Pavel Skripkin wrote:
> Syzbot has reported warning in __flush_work(). This warning is caused by
> work->func == NULL, which means missing work initialization.
>
> This may happen, since input_dev->close() calls cancel_work_sync(&dev->work),
> but dev->work initalization happens _after_ input_register_device()
> call.
>
> So this patch moves dev->work initialization before registering input
> device
>
> Fixes: 5a6eb676d3bc ("Input: appletouch - improve powersaving for Geyser3 devices")
> Reported-and-tested-by: syzbot+b88c5eae27386b252bbd@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-12-31 5:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 14:11 [PATCH] input: appletouch: initialize work before device registration Pavel Skripkin
2021-12-31 5:04 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc6PUmjd4BDctN9h@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=kernel@nn7.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+b88c5eae27386b252bbd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox